⚓ T164308 [regression wmf.21] Safari only - filter capsules with highlight displayed misalgned

	Subject	Repo	Branch	Lines +/-
	RCFilters: Align TagItemWidget highlight in Safari	mediawiki/core	master	+0 -1

Etonkovidova created this task.May 2 2017, 9:59 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 2 2017, 9:59 PM

Etonkovidova updated the task description. (Show Details)May 2 2017, 10:00 PM

Etonkovidova added a subscriber: Volker_E.May 2 2017, 11:16 PM

• jmatazzoni moved this task from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017) board.May 9 2017, 8:50 PM

Bump. This is still happening.

Change 363396 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] RCFilters: Align TagItemWidget highlight in Safari

https://gerrit.wikimedia.org/r/363396

gerritbot added a project: Patch-For-Review.Jul 5 2017, 8:01 PM

Checked https://gerrit.wikimedia.org/r/363396 -- the highlight circle is aligned properly:

Screen Shot 2017-07-05 at 3.20.08 PM.png (486×935 px, 124 KB)

In T164308#3409649, @Etonkovidova wrote:

Checked https://gerrit.wikimedia.org/r/363396 -- the highlight circle is aligned properly:

Way better but the text string is still not vertically centered. It seems closer to the bottom than the top. Unless that was the intended design. :)
Sorry for nitpicking!

@Niharika That's not necessarily intended design, but rather connected to T168089 and architecturally more deeper T97631. Please file another task for it or mention it on one of the two tasks.

Checked with SauceLabs the following combinations and highlight with new filters look fine:

Windows7 + IE11, IE10, IE9
Windows10 + IE11
Windows10+ MicrosoftEdge 15

Screen Shot 2017-07-07 at 12.41.46 PM.png (450×868 px, 159 KB)

Screen Shot 2017-07-07 at 12.28.52 PM.png (502×657 px, 93 KB)

Screen Shot 2017-07-07 at 1.14.55 PM.png (301×693 px, 57 KB)

Older IE browsers (IE9 and IE8) default RC page to no-JS mode (by design).

Change 363396 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Align TagItemWidget highlight in Safari

https://gerrit.wikimedia.org/r/363396

ReleaseTaggerBot added a project: MW-1.30-release-notes.Jul 11 2017, 1:00 AM

Volker_E claimed this task.Jul 11 2017, 11:31 AM

Volker_E removed a project: Patch-For-Review.

Volker_E removed a subscriber: gerritbot.

Etonkovidova mentioned this in T170190: RC Legend - the highlight color is displayed over the Legend .Jul 11 2017, 10:07 PM

• jmatazzoni edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage (Collab-Team-Q4-Apr-Jun-2017).Jul 12 2017, 9:58 PM

• jmatazzoni moved this task from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jul 12 2017, 10:24 PM

Re-checked betalabs and plwiki (1.31.0-wmf.2) - the issue is fixed.

Etonkovidova closed this task as Resolved.Oct 11 2017, 7:15 PM

• jmatazzoni moved this task from Ready for Pickup to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Oct 11 2017, 7:28 PM

[regression wmf.21] Safari only - filter capsules with highlight displayed misalgned
Closed, ResolvedPublic
Actions

Description

Details

Related Objects

Event Timeline

	F8648970: Screen Shot 2017-07-07 at 12.41.46 PM.png
	Jul 7 2017, 8:37 PM

	F8648975: Screen Shot 2017-07-07 at 12.28.52 PM.png
	Jul 7 2017, 8:37 PM

	F8648978: Screen Shot 2017-07-07 at 1.14.55 PM.png
	Jul 7 2017, 8:37 PM

	F8626521: Screen Shot 2017-07-05 at 3.20.08 PM.png
	Jul 5 2017, 10:27 PM

	F7880977: Screen Shot 2017-05-02 at 2.57.26 PM.png
	May 2 2017, 9:59 PM

	F7880982: Screen Shot 2017-05-02 at 2.53.34 PM.png
	May 2 2017, 9:59 PM

[regression wmf.21] Safari only - filter capsules with highlight displayed misalgned Closed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

[regression wmf.21] Safari only - filter capsules with highlight displayed misalgned
Closed, ResolvedPublic
Actions