Page MenuHomePhabricator
Create Task
Maniphest T170190

RC Legend - the highlight color is displayed over the Legend
Closed, ResolvedPublic
Actions

Assigned To
• jmatazzoni
Authored By
Etonkovidova
Jul 10 2017, 7:34 PM
Tags
Referenced Files
F8707498: Screen Shot 2017-07-11 at 2.59.06 PM.png
Jul 11 2017, 10:07 PM
F8695913: Screen Shot 2017-07-10 at 2.10.03 PM.png
Jul 10 2017, 9:11 PM
F8695817: Screen Shot 2017-07-10 at 2.07.46 PM.png
Jul 10 2017, 9:08 PM
F8694552: Screen Shot 2017-07-10 at 12.27.32 PM.png
Jul 10 2017, 7:34 PM
F8694548: Screen Shot 2017-07-10 at 12.25.53 PM.png
Jul 10 2017, 7:34 PM
Subscribers
Aklapper
Catrope
Etonkovidova
gerritbot
• jmatazzoni
Mooeypoo
Volker_E

Description

Screen Shot 2017-07-10 at 12.25.53 PM.png (265×1 px, 129 KB)

Note: With " Enhanced recent changes " option enabled, the text wraps around the Legend

Screen Shot 2017-07-10 at 12.27.32 PM.png (252×1 px, 119 KB)

Details

SubjectRepoBranchLines +/-
RCFilters: Add white background to legendmediawiki/coremaster+4 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Etonkovidova created this task.Jul 10 2017, 7:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 10 2017, 7:34 PM
• jmatazzoni assigned this task to Mooeypoo.Jul 10 2017, 7:49 PM
• jmatazzoni added a parent task: T168043: Adjust the legend on Recent Changes page.
• jmatazzoni edited projects, added Edit-Review-Improvements-Integrated-Filters; removed Edit-Review-Improvements-RC-Page.
• jmatazzoni moved this task from Untriaged to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
• jmatazzoni subscribed.
Catrope removed Mooeypoo as the assignee of this task.Jul 10 2017, 7:51 PM
Catrope added a subscriber: Mooeypoo.
Mooeypoo added a comment.Jul 10 2017, 8:11 PM

I don't see this in Chrome or Firefox on ubuntu. What browser did you see this in?

Etonkovidova added a comment.Jul 10 2017, 8:17 PM

Both Chrome and FF 54 (on Mac)display the issue. How it's displayed in Ubuntu? The un-collapsed Legend is not transparent?

• jmatazzoni added a comment.Jul 10 2017, 9:08 PM

I see it in Chrome. See below.

Screen Shot 2017-07-10 at 2.07.46 PM.png (431×1 px, 140 KB)

Catrope subscribed.Jul 10 2017, 9:10 PM
In T170190#3422558, @Mooeypoo wrote:

I don't see this in Chrome or Firefox on ubuntu. What browser did you see this in?

Note that per the bug report, this only happens in non-enhanced mode. You don't need to change your prefs to disable/enable enhanced mode, you can just use ?enhanced=0.

• jmatazzoni added a comment.Jul 10 2017, 9:11 PM

Actually, also in Safari.

Screen Shot 2017-07-10 at 2.10.03 PM.png (437×1 px, 141 KB)

Second issue: do you see the misaligned Talk tag in this screenshot? Has that been reported?

Mooeypoo added a comment.Jul 10 2017, 9:21 PM
In T170190#3422803, @jmatazzoni wrote:

Actually, also in Safari.

Screen Shot 2017-07-10 at 2.10.03 PM.png (437×1 px, 141 KB)

Second issue: do you see the misaligned Talk tag in this screenshot? Has that been reported?

Yes, that's safari issue, I believe there should be a fix for it up for review (I'll double check)

Mooeypoo added a comment.Jul 10 2017, 9:22 PM
In T170190#3422783, @Catrope wrote:
In T170190#3422558, @Mooeypoo wrote:

I don't see this in Chrome or Firefox on ubuntu. What browser did you see this in?

Note that per the bug report, this only happens in non-enhanced mode. You don't need to change your prefs to disable/enable enhanced mode, you can just use ?enhanced=0.

I actually did miss that, oy. Sorry. Double-checking now.

gerritbot subscribed.Jul 10 2017, 9:58 PM

Change 364330 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/core@master] RCFilters: Add white background to legend

https://gerrit.wikimedia.org/r/364330

gerritbot added a project: Patch-For-Review.Jul 10 2017, 9:58 PM
Mooeypoo moved this task from Ready for Pickup to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jul 10 2017, 9:58 PM
gerritbot added a comment.Jul 11 2017, 12:25 AM

Change 364330 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Add white background to legend

https://gerrit.wikimedia.org/r/364330

Catrope moved this task from Needs Review to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jul 11 2017, 12:41 AM
ReleaseTaggerBot added a project: MW-1.30-release-notes.Jul 11 2017, 1:00 AM
Etonkovidova added a subscriber: Volker_E.Jul 11 2017, 10:07 PM

Checked in betalabs and in 1.30.0-wmf.9 (testwiki).

Screen Shot 2017-07-11 at 2.59.06 PM.png (212×1 px, 116 KB)

QA Recommendation: Resolve

@jmatazzoni T164308: [regression wmf.21] Safari only - filter capsules with highlight displayed misalgned was filed and @Volker_E has is fixing it.

Etonkovidova moved this task from QA Review to Product Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Jul 11 2017, 10:18 PM
• jmatazzoni closed this task as Resolved.Jul 11 2017, 11:02 PM
• jmatazzoni claimed this task.
• Petar.petkovic mentioned this in T186841: Highlight color is displayed over the legend on RC page.Feb 9 2018, 1:07 AM
• Petar.petkovic removed a project: Patch-For-Review.Mar 6 2018, 7:24 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL