Page MenuHomePhabricator
Create Task
Maniphest T164309

Consolidate page disambiguations and page issues
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Related files:
apps-android-wikipedia/www/js/disambig.js
apps-android-wikipedia/www/js/issues.js
apps-android-wikipedia/www/js/sections.js
MobileApp/styles/disambig.less
MobileApp/styles/issues.less

Page issue presentation is similar on both platforms. Disambiguations are broken on iOS but would normally appear about the same. Hatnotes are broken on Android and presented inline on iOS.

Consolidation of disambiguation Android in-page presentation should be discussed with product since iOS just shows these disambiguations inline without any changes from the original HTML.

Screenshot of inline disambig/page issues on iOS (we don't hide hatnotes):

Screen Shot 2017-06-08 at 2.32.10 PM.png (1×862 px, 249 KB)

Related Objects
Search...

Event Timeline

• Niedzielski created this task.May 2 2017, 10:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 2 2017, 10:10 PM
• Niedzielski triaged this task as Medium priority.May 2 2017, 10:16 PM
• Niedzielski added a parent task: T163839: Phase one: consolidate the JavaScript transforms and associated CSS.
• Niedzielski updated the task description. (Show Details)
• Niedzielski moved this task from Open to Phase One on the wikimedia-page-library board.May 3 2017, 10:14 PM
• Niedzielski edited projects, added wikimedia-page-library-tshirt; removed wikimedia-page-library.May 11 2017, 9:31 PM
• Niedzielski created subtask T165422: Integrate page disambiguations and page issues on Android.May 15 2017, 10:16 PM
• Niedzielski created subtask T165423: Integrate page disambiguations and page issues on iOS.
• Niedzielski updated the task description. (Show Details)May 15 2017, 10:35 PM
Mhurd subscribed.May 22 2017, 9:38 PM

Android and iOS may have diverged on hatnote handling... we may want to check in with product owners before starting this one.

• Niedzielski updated the task description. (Show Details)Jun 8 2017, 9:01 PM
• Niedzielski updated the task description. (Show Details)
• Niedzielski renamed this task from Consolidate hatnotes, similar pages/ page disambiguations, page issues to Consolidate page disambiguations and page issues.Jun 8 2017, 9:16 PM
• Niedzielski updated the task description. (Show Details)Jun 8 2017, 9:32 PM
Mhurd updated the task description. (Show Details)Jun 8 2017, 9:33 PM
• Niedzielski updated the task description. (Show Details)Jun 8 2017, 9:35 PM
• Niedzielski updated the task description. (Show Details)
• Niedzielski moved this task from Backlog to M on the wikimedia-page-library-tshirt board.Jun 8 2017, 9:41 PM
• Niedzielski set the point value for this task to 2.
Mhurd claimed this task.EditedJan 5 2018, 9:58 PM
Mhurd added a project: iOS-app-v5.8.0-Manatee-On-A-Skateboard.
Mhurd moved this task from Tasks from Product Backlog to Doing on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.
Mhurd added a subscriber: • Fjalapeno.

Per conversation with @Fjalapeno, I'm pulling the JS for page issue and disambiguation extraction into their own transforms (or utilities?). Will make it easier to re-use.

Mhurd updated the task description. (Show Details)Jan 10 2018, 12:02 AM
Mhurd added a comment.Jan 10 2018, 12:59 AM

https://github.com/wikimedia/wikimedia-page-library/pull/121

Mhurd moved this task from Doing to Needs Code Review on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Jan 10 2018, 12:59 AM
Mhurd closed subtask T165423: Integrate page disambiguations and page issues on iOS as Resolved.Jan 10 2018, 1:04 AM
Mhurd moved this task from Needs Code Review to Needs Testing Criteria on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Jan 16 2018, 12:27 AM
Dbrant subscribed.Jan 18 2018, 3:43 PM

Note: Android no longer hides hatnotes.

Mhurd moved this task from Needs Testing Criteria to Ready for PM Signoff on the iOS-app-v5.8.0-Manatee-On-A-Skateboard board.Mar 6 2018, 7:20 PM
• JMinor closed this task as Resolved.Mar 12 2018, 7:10 PM
• Charlotte closed subtask T165422: Integrate page disambiguations and page issues on Android as Declined.Aug 19 2019, 4:24 PM
Restricted Application added a project: Wikipedia-iOS-App-Backlog. · View Herald TranscriptAug 19 2019, 4:24 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits