Page MenuHomePhabricator

Switch article footer read more back to vertical layout
Closed, ResolvedPublic

Description

Per our decision to postpone horizontal interaction to future date/ticket.

Screen Shot 2017-05-02 at 4.56.07 PM.png (1×862 px, 289 KB)

Testing criteria:

  • Load an article and scroll to the bottom
  • Ensure the Read more cards at the bottom of the article are stacked vertically (as seen in the screenshot above)

Event Timeline

JMinor triaged this task as Medium priority.May 3 2017, 4:26 PM
cmadeo subscribed.

@Mhurd I'm still seeing the horizontal layout on Alpha 5.4.1 (1128). The screenshot above looks good though. Moving this to blocked or waiting for now, but if the review is of the screenshot above or the one in Github and not of the implementation I can move this along, just let me know. Thanks!

@cmadeo This should be in build 1134 now. Note that there's a upstream bug with text extracts at the moment and a bug with the footer read more transform never using the wikidata description, but those are know and either being worked on (the upstream extracts issue) or will be fixed soon (the description issue - i'm making a ticket for that). This ticket's just about the vertical layout.

Macro votecat: Looks  good

More design updates to follow, but for now this matches the spec and looks good!

ABorbaWMF subscribed.

Tested on an iPhone 7+ with iOS 10.3 and an iPad Mini 2 Retina on Beta App 5.5.0 (1134)