Page MenuHomePhabricator

"The popover opt-in invitation" will be displayed for users who opt-out of "New filters for edit review"
Closed, ResolvedPublic

Description

The popover opt-in invitation was implemented per https://phabricator.wikimedia.org/T144457.

Presently a user who disables "New filters for edit review", will see the popover opt-in invite (only for the first time of opting out as per spec).

  1. A user who has enabled "New filters for edit review" before the popover opt-in invitation was implemented - the user properties for RC filters are the following:
 SELECT up_property, up_value FROM user_properties WHERE up_property  LIKE 'rcenhanced%' AND up_user=6900;
+---------+-------------------------------+----------+
| up_user | up_property                   | up_value |
+---------+-------------------------------+----------+
|    6900 | rcenhancedfilters             | 1        |
|    6900 | rcenhancedfilters-seen-tour   | 1        |
+---------+-------------------------------+----------+
2 rows in set (0.01 sec)
  1. The user_id=6900 disables "New filters for edit review" - the user properties will be:
+---------+-------------------------------+----------+
| up_user | up_property                   | up_value |
+---------+-------------------------------+----------+
|    6900 | rcenhancedfilters-seen-tour   | 1        |
+---------+-------------------------------+----------+
  1. The user_id=6900 visits RC page and sees the popover opt-in invitation. The rcenhancedfilters-seen-invite will be in user_properties and after that no the popover opt-in invitation will be ever displayed.
+---------+-------------------------------------------------+----------+
| up_user | up_property                                     | up_value |
+---------+-------------------------------------------------+----------+
|    6900 | rcenhancedfilters-seen-highlight-button-counter | 1        |
|    6900 | rcenhancedfilters-seen-invite                   | 1        |
|    6900 | rcenhancedfilters-seen-tour                     | 1        |
+---------+-------------------------------------------------+----------+

Details

Related Gerrit Patches:
mediawiki/extensions/WikimediaMessages : masterRC Filters: Do not show 'invite' to users who have seen 'welcome'

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 5 2017, 11:13 PM

So the idea here is that if you've opted out, you've opted out. We should stop bothering you? It's a nice thought, if it can be done without too much effort. Engineers?

I'm sure there are a variety of ways to interpret this. One would be to make it so that if you've seen/dismissed the invitation, you will never see it again, no matter what. (In this case, if you somehow enabled the beta without having seen the invitation, then disabled it, you would see the invitation. But only one time.)

So the idea here is that if you've opted out, you've opted out. We should stop bothering you? It's a nice thought, if it can be done without too much effort. Engineers?

We don't really know if a user has turned the beta feature ON and then OFF. However, we keep track of which users have seen the 'Welcome' tour so we could decide that they are aware of the feature and don't need to be invited even if they have the beta feature currently OFF.

I'm sure there are a variety of ways to interpret this. One would be to make it so that if you've seen/dismissed the invitation, you will never see it again, no matter what. (In this case, if you somehow enabled the beta without having seen the invitation, then disabled it, you would see the invitation. But only one time.)

That's exactly how it works now. The invitation is shown only once.

Change 352597 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/WikimediaMessages@master] RC Filters: Do not show 'invite' to users who have seen 'welcome'

https://gerrit.wikimedia.org/r/352597

Change 352597 merged by jenkins-bot:
[mediawiki/extensions/WikimediaMessages@master] RC Filters: Do not show 'invite' to users who have seen 'welcome'

https://gerrit.wikimedia.org/r/352597

@Etonkovidova the merged patch above makes it so that users who have used the feature in the past and seen the "Welcome" tour won't be presented with the invitation. Do you think it resolves this task?

@SBisson yes, I re-checked - it's working. The popover won't be shown to users who disable "New filters for edit review" beta feature.

QA Recommendation: Resolve

jmatazzoni closed this task as Resolved.May 8 2017, 9:15 PM
jmatazzoni claimed this task.