Page MenuHomePhabricator

Remove output during automated tests
Closed, ResolvedPublic3 Estimated Story Points

Description

During execution of phpunit of the fundraising-backend code the string Response is not a JSON array is printed to the output by FundraisingFrontendService. This does not make any test fail, it's just kind of ugly.

Acceptance criteria:

  • There is no output written to stdout or stderr in any code that is executed during tests.

Event Timeline

kai.nissen set the point value for this task to 3.
kai.nissen moved this task from Backlog to Sprint ready on the WMDE-Fundraising-Tech board.
  • Is this caused by an e2e test? => Nope
  • Is this caused by an Integration test? => Nope
  • Is this caused by a unit test? => Yep
  • Unit test hangs for 10 seconds until the request timeouts and then pollutes the test output

... the fail is strong in this one

Actually the 10 sec and test output came from different tests.

Fixed by https://github.com/wmde/fundraising-backend/pull/267

Deployed to test and production just now