Page MenuHomePhabricator
Create Task
Maniphest T166247

Remove EventLogging for cookie blocks
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Now that we are fairly confident that cookie blocks aren't causing any problems, let's remove the EventLogging. This involves first removing code from WikimediaEventsHooks.php in the WikimediaEvents extension and then removing the blockTrigger code from core (as this is only for EventLogging AFAIK).

See T146230 and T162215 for background.

Details

SubjectRepoBranchLines +/-
Remove temporary hole in abstractionsmediawiki/coremaster+0 -12
Remove temporary cookie block loggingmediawiki/extensions/WikimediaEventsmaster+0 -24
Customize query in gerrit

Related Objects

Event Timeline

kaldari created this task.May 24 2017, 6:24 PM
Restricted Application added a project: Analytics. · View Herald TranscriptMay 24 2017, 6:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
kaldari moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.May 24 2017, 6:25 PM
• Nuria moved this task from Incoming to Radar on the Analytics board.May 25 2017, 4:17 PM
• DannyH triaged this task as Medium priority.May 31 2017, 5:16 PM
• DannyH set the point value for this task to 1.
• DannyH moved this task from Needs Discussion to Up Next (May 20-June 3) on the Community-Tech board.
kaldari lowered the priority of this task from Medium to Low.Jun 20 2017, 11:16 PM
kaldari moved this task from Up Next (May 20-June 3) to Needs Discussion on the Community-Tech board.
kaldari moved this task from Needs Discussion to Up Next (May 20-June 3) on the Community-Tech board.Jun 20 2017, 11:38 PM
MaxSem claimed this task.Jul 14 2017, 10:39 PM
MaxSem added a project: Community-Tech-Sprint.
gerritbot subscribed.Jul 14 2017, 10:44 PM

Change 365414 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/WikimediaEvents@master] Remove temporary cookie block logging

https://gerrit.wikimedia.org/r/365414

gerritbot added a project: Patch-For-Review.Jul 14 2017, 10:44 PM
kaldari closed this task as Resolved.Jul 14 2017, 11:29 PM
kaldari moved this task from Ready to Q1 2018-19 on the Community-Tech-Sprint board.
gerritbot added a comment.Jul 14 2017, 11:31 PM

Change 365414 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@master] Remove temporary cookie block logging

https://gerrit.wikimedia.org/r/365414

gerritbot added a comment.Jul 14 2017, 11:38 PM

Change 365419 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/core@master] Remove temporary hole in abstractions

https://gerrit.wikimedia.org/r/365419

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)).Jul 15 2017, 12:01 AM
gerritbot added a comment.Jul 15 2017, 12:20 AM

Change 365419 merged by jenkins-bot:
[mediawiki/core@master] Remove temporary hole in abstractions

https://gerrit.wikimedia.org/r/365419

ReleaseTaggerBot edited projects, added MW-1.30-release-notes; removed MW-1.30-release-notes (WMF-deploy-2017-07-18_(1.30.0-wmf.10)).Jul 15 2017, 1:00 AM
Krinkle awarded a token.Jul 15 2017, 1:11 AM
• DannyH removed a project: Community-Tech-Sprint.Jul 18 2017, 10:43 PM
• DannyH moved this task from Up Next (May 20-June 3) to Archive on the Community-Tech board.Jul 18 2017, 10:47 PM
Aklapper edited projects, added Analytics-Radar; removed Analytics.Jun 10 2020, 6:44 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL