NullStatsdDataFactory can't be used as StatsdDataFactory service
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Smalyshev
	May 26 2017, 12:04 AM

Description

If we try to use NullStatsdDataFactory instead of BufferingStatsdDataFactory, we get this error:

PHP Fatal error:  Call to undefined method NullStatsdDataFactory::getBuffer() in /srv/mediawiki/php-1.30.0-wmf.2/includes/GlobalFunctions.php on line 1203

This is because the code in wfLogProfilingData() calls getBuffer() which is not part of StatsdDataFactoryInterface. We should refactor it so that core code uses proper interfaces and both "null" and "buffered" classes implement them.

Additionally, getStatsdDataFactory) is defines as returning StatsdDataFactory not StatsdDataFactoryInterface, which makes NullStatsdDataFactory class inapplicable for this interface.

Details

	Subject	Repo	Branch	Lines +/-
	statsd: Rename MediawikiStatsdDataFactory to IBufferingStatsdDataFactory	mediawiki/core	master	+14 -12
	Refactor Statsd classes to enable null collector to work.	mediawiki/core	master	+104 -13

Customize query in gerrit

Related Objects

Mentioned In: T165203: Archive reindex gets stuck

Event Timeline

Smalyshev created this task.May 26 2017, 12:04 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 26 2017, 12:04 AM

bd808 edited projects, added MediaWiki-General; removed MediaWiki-Logevents, MediaWiki-Core-Team.May 26 2017, 12:05 AM

Smalyshev mentioned this in T165203: Archive reindex gets stuck.May 26 2017, 12:27 AM

Change 355733 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[mediawiki/core@master] Refactor Statsd classes to enable null collector to work.

https://gerrit.wikimedia.org/r/355733

gerritbot added a project: Patch-For-Review.May 26 2017, 12:28 AM

Smalyshev added a subscriber: Tgr.May 26 2017, 12:30 AM

Change 355733 merged by jenkins-bot:
[mediawiki/core@master] Refactor Statsd classes to enable null collector to work.

https://gerrit.wikimedia.org/r/355733

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-05-30_(1.30.0-wmf.3)).May 30 2017, 4:00 AM

Smalyshev closed this task as Resolved.Jun 1 2017, 6:53 PM

Smalyshev claimed this task.

Mass-moving all items tagged for MediaWiki 1.30.0-wmf.3, as that was never released; instead, we're using -wmf.4.

Change 363997 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] statsd: Rename MediawikiStatsdDataFactory to IBufferingStatsdDataFactory

https://gerrit.wikimedia.org/r/363997

Krinkle edited projects, added MediaWiki-Debug-Logger; removed Patch-For-Review, MediaWiki-General, Performance Issue.Jul 8 2017, 12:30 AM

Change 363997 merged by jenkins-bot:
[mediawiki/core@master] statsd: Rename MediawikiStatsdDataFactory to IBufferingStatsdDataFactory