Page jump in Minerva/mobile skin with section link or reference in URL
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Firefox (desktop). On https://en.m.wikipedia.beta.wmflabs.org/wiki/Channel_Tunnel, I clicked the [A] link, clicked the caret to go back to [A], and then clicked reference 9. The page scrolled back to [A] for no reason, although the popup displayed. (I think this also happened on my phone earlier with a section link.)

Replication

Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Channel_Tunnel#cite_note-6
Click reference link
Expected: Reference drawer shows and no scroll position change
Actual: drawer shows but navigates to bottom of page

Details

	Subject	Repo	Branch	Lines +/-
	Don't checkHash for reference links	mediawiki/extensions/MobileFrontend	master	+2 -1

Customize query in gerrit

Related Objects

Mentioned In: T154861: Clicking certain references results in infinite spinner on mobile

Event Timeline

Jc86035 created this task.May 30 2017, 9:20 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 30 2017, 9:20 AM

Jc86035 added a project: MobileFrontend.May 30 2017, 9:20 AM

Jc86035 mentioned this in T154861: Clicking certain references results in infinite spinner on mobile.May 30 2017, 10:14 AM

ovasileva triaged this task as Medium priority.May 30 2017, 11:00 AM

ovasileva added a project: Web-Team-Backlog.

ovasileva moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.

I can confirm this.

@bmansurov looks like we discovered what that timeout you had me remove was for... :)

https://phabricator.wikimedia.org/T154861#3299693 seems to explain the problem here well

Awesome. It would be great if we can document that code this time around.

Exactly my thinking!

Seems like a 1 pointer, so adding to sprint.

Jdlrobson moved this task from To Do to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.May 30 2017, 6:33 PM

Jdlrobson lowered the priority of this task from Medium to Low.May 30 2017, 7:10 PM

Jdlrobson claimed this task.May 30 2017, 9:58 PM

Jdlrobson moved this task from Needs Design Review to Doing on the Readers-Web-Kanbanana-Board-Old board.

Didn't get anywhere with this....

ovasileva raised the priority of this task from Low to Medium.May 31 2017, 11:56 AM

ovasileva moved this task from Needs Design Review to To Do on the Readers-Web-Kanbanana-Board-Old board.

ovasileva moved this task from To Do to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.

Jdlrobson updated the task description. (Show Details)May 31 2017, 5:13 PM

• NHarateh_WMF set the point value for this task to 3.May 31 2017, 5:14 PM

Jdlrobson moved this task from Needs Design Review to To Do on the Readers-Web-Kanbanana-Board-Old board.May 31 2017, 5:15 PM

Jdlrobson removed a project: Unplanned-Sprint-Work.

• NHarateh_WMF moved this task from To Do to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.May 31 2017, 5:27 PM

Jdlrobson moved this task from Needs Prioritization to 2016-17 Q4 on the Web-Team-Backlog board.May 31 2017, 6:32 PM

Change 357333 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Don't checkHash for reference links

https://gerrit.wikimedia.org/r/357333

gerritbot added a project: Patch-For-Review.Jun 6 2017, 12:26 AM

The issue is in the Toggler. I'm not really sure how to encapsulate it in a test. That code needs a lot of love...

• bmansurov moved this task from Needs Code Review to Needs QA on the Readers-Web-Kanbanana-Board-Old board.Jun 7 2017, 5:37 PM

Change 357333 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Don't checkHash for reference links

https://gerrit.wikimedia.org/r/357333

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-06-13_(1.30.0-wmf.5)).Jun 7 2017, 6:00 PM

Can you verify the fix and do a quick check of the feature?

Tried this on a handful of devices using browserstack. All the references looked good and the [A] reference worked properly.

Tested - https://en.m.wikipedia.org/w/index.php?title=Channel_Tunnel&oldid=757761414#Passenger_traffic_volumes

Page jump in Minerva/mobile skin with section link or reference in URLClosed, ResolvedPublic3 Estimated Story PointsActions