Page MenuHomePhabricator
Create Task
Maniphest T167399

Translate constraint type Q-IDs into strings
Closed, ResolvedPublic
Actions

Description

Constraint already has the separate methods getConstraintTypeQid and getConstraintTypeName, but currently they both return the same value. We should make getConstraintTypeName return the label of the constraint item, and then check if all uses of the two methods are correct (e. g. which one to inject into messages).

Details

SubjectRepoBranchLines +/-
Use constraint type item ID in remaining error messagesmediawiki/extensions/WikibaseQualityConstraintsmaster+105 -27
Remove getConstraintName and getConstraintTypeNamemediawiki/extensions/WikibaseQualityConstraintsmaster+9 -64
Improve link to constraint definition in special pagemediawiki/extensions/WikibaseQualityConstraintsmaster+28 -14
Add link to constraint definition in gadgetmediawiki/extensions/WikibaseQualityConstraintsmaster+71 -8
Use constraint type item ID in ConstraintParameterParsermediawiki/extensions/WikibaseQualityConstraintsmaster+49 -42
Pass Constraint object into CheckResultmediawiki/extensions/WikibaseQualityConstraintsmaster+77 -68
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jun 8 2017, 10:54 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 8 2017, 10:54 AM
Lucas_Werkmeister_WMDE added a parent task: T102759: [Story] Migrate constraints from property talk pages to statements on properties.Jun 8 2017, 10:55 AM
Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.Jun 11 2017, 4:29 PM
Lydia_Pintscher triaged this task as Medium priority.Jun 11 2017, 4:44 PM
gerritbot subscribed.Jun 26 2017, 4:52 PM

Change 361486 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Pass Constraint object into CheckResult

https://gerrit.wikimedia.org/r/361486

gerritbot added a project: Patch-For-Review.Jun 26 2017, 4:52 PM
Lucas_Werkmeister_WMDE moved this task from Backlog to DOING on the Wikibase-Quality board.Jun 26 2017, 4:52 PM
Lucas_Werkmeister_WMDE added a project: Wikidata-Former-Sprint-Board.
Lucas_Werkmeister_WMDE moved this task from ready to go to in progress on the Wikidata board.
Lucas_Werkmeister_WMDE moved this task from Proposed to Doing on the Wikidata-Former-Sprint-Board board.
gerritbot added a comment.Jun 28 2017, 7:12 PM

Change 361932 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Use constraint type item ID in ConstraintParameterParser

https://gerrit.wikimedia.org/r/361932

gerritbot added a comment.Jun 29 2017, 11:44 AM

Change 362176 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Use constraint type item ID in remaining error messages

https://gerrit.wikimedia.org/r/362176

Lucas_Werkmeister_WMDE moved this task from DOING to REVIEW on the Wikibase-Quality board.Jun 29 2017, 11:45 AM
Lucas_Werkmeister_WMDE moved this task from Doing to Review on the Wikidata-Former-Sprint-Board board.
gerritbot added a comment.Jun 29 2017, 3:47 PM

Change 362222 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add link to constraint definition in gadget

https://gerrit.wikimedia.org/r/362222

gerritbot added a comment.Jun 29 2017, 3:47 PM

Change 362223 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Improve link to constraint definition in special page

https://gerrit.wikimedia.org/r/362223

gerritbot added a comment.Jun 29 2017, 3:47 PM

Change 362224 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove getConstraintName and getConstraintTypeName

https://gerrit.wikimedia.org/r/362224

gerritbot added a comment.Jun 30 2017, 9:18 AM

Change 361486 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Pass Constraint object into CheckResult

https://gerrit.wikimedia.org/r/361486

gerritbot added a comment.Jun 30 2017, 9:20 AM

Change 361932 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Use constraint type item ID in ConstraintParameterParser

https://gerrit.wikimedia.org/r/361932

gerritbot added a comment.Jun 30 2017, 12:41 PM

Change 362176 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Use constraint type item ID in remaining error messages

https://gerrit.wikimedia.org/r/362176

• Jonas closed this task as Resolved.Jun 30 2017, 12:42 PM
• Jonas moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.
gerritbot added a comment.Jun 30 2017, 12:45 PM

Change 362222 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add link to constraint definition in gadget

https://gerrit.wikimedia.org/r/362222

gerritbot added a comment.Jun 30 2017, 12:56 PM

Change 362223 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Improve link to constraint definition in special page

https://gerrit.wikimedia.org/r/362223

gerritbot added a comment.Jun 30 2017, 12:59 PM

Change 362224 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Remove getConstraintName and getConstraintTypeName

https://gerrit.wikimedia.org/r/362224

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL