Page MenuHomePhabricator
Create Task
Maniphest T102759

[Story] Migrate constraints from property talk pages to statements on properties
Closed, ResolvedPublic
Actions

Description

Currently, every user can define constraints on property talk pages in a certain syntax. It would be way better to have the constraints defines as statements on properties.

Details

SubjectRepoBranchLines +/-
Update special page explanation for constraint statementsmediawiki/extensions/WikibaseQualityConstraintsmaster+1 -1
Add some support for somevalue and novaluemediawiki/extensions/WikibaseQualityConstraintsmaster+246 -25
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedLydia_PintscherT99351 Review and deploy Wikibase-Quality on wikidata.org
 ResolvedLydia_PintscherT99354 Review and deploy Wikibase-Quality-Constraints on wikidata.org
 InvalidNoneT103817 [Epic] version 2 of the quality extensions
 InvalidTamsloT103108 Deal with Exceptions
 InvalidNoneT104205 [Task] Adapt data types in Violation
 ResolvedLucas_Werkmeister_WMDET102759 [Story] Migrate constraints from property talk pages to statements on properties
 ResolvedLucas_Werkmeister_WMDET102760 [Task] Hooks to keep constraint table up to date.
 ResolvedLucas_Werkmeister_WMDET167106 Import type and value type constraints from statements
 ResolvedLucas_Werkmeister_WMDET167107 Import inverse constraints from statements
 ResolvedLucas_Werkmeister_WMDET167108 Import item constraints from statements
 ResolvedLucas_Werkmeister_WMDET167109 Import target required claim constraints from statements
 ResolvedLucas_Werkmeister_WMDET167110 Import conflicts with constraints from statements
 ResolvedLucas_Werkmeister_WMDET167111 Import one of constraints from statements
 ResolvedLucas_Werkmeister_WMDET167399 Translate constraint type Q-IDs into strings
 ResolvedLucas_Werkmeister_WMDET167413 Import range constraints from statements
 ResolvedLucas_Werkmeister_WMDET167414 Import diff within range constraints from statements
 ResolvedLucas_Werkmeister_WMDET167415 Import qualifiers constraints from statements
 ResolvedLucas_Werkmeister_WMDET167416 Import mandatory qualifiers constraints from statements
 ResolvedLucas_Werkmeister_WMDET167417 Import commons link constraints from statements
 ResolvedLucas_Werkmeister_WMDET167418 Import format constraints from statements
 ResolvedLucas_Werkmeister_WMDET169430 Import constraint exceptions from constraint statements
 ResolvedhooT169647 Enable constraint statements on Wikidata
 ResolvedLucas_Werkmeister_WMDET169218 Create maintenance script to run constraintsTableUpdate jobs for all properties

Event Timeline

Jonaskeutel created this task.Jun 17 2015, 8:55 AM
Jonaskeutel raised the priority of this task from to High.
Jonaskeutel updated the task description. (Show Details)
Jonaskeutel added projects: Wikibase-Quality-Constraints, Wikidata.
Jonaskeutel moved this task from incoming to DOING on the Wikibase-Quality-Constraints board.
Jonaskeutel added subscribers: Aklapper, Jonaskeutel.
Jonaskeutel added a subtask: T102760: [Task] Hooks to keep constraint table up to date..Jun 17 2015, 8:57 AM
Lydia_Pintscher subscribed.Jun 17 2015, 9:30 AM

Can you please indicate the status of this? You already had some scripts? Can you link them please?

Tamslo added a project: Wikibase-Quality.Jun 19 2015, 2:43 PM
Tamslo set Security to None.
Tamslo moved this task from Backlog to Beyond our power on the Wikibase-Quality board.Jun 19 2015, 2:56 PM
Andreasburmeister moved this task from Beyond our power to DOING on the Wikibase-Quality board.Jun 22 2015, 11:06 AM
Tamslo moved this task from DOING to incoming on the Wikibase-Quality-Constraints board.Jun 22 2015, 11:09 AM
Tamslo assigned this task to Andreasburmeister.Jun 22 2015, 11:18 AM
Tamslo added a parent task: T103108: Deal with Exceptions.Jun 22 2015, 11:45 AM
Jonaskeutel added a comment.Jun 22 2015, 11:45 AM

We are working together with Amir (Ladsgroup) to get this done.

On this Github repo, you can see the current state. Their is a blocking issue with the PyWikiBot, but there is already a patch for T103303.

Andreasburmeister added a subscriber: Ladsgroup.Jun 22 2015, 11:59 AM
Lydia_Pintscher moved this task from incoming to monitoring on the Wikidata board.Jun 24 2015, 10:37 AM
Tamslo added a parent task: T104205: [Task] Adapt data types in Violation.Jun 29 2015, 4:12 PM
Lydia_Pintscher renamed this task from Migrate constraints from property talk pages to statements on properties to [Story] Migrate constraints from property talk pages to statements on properties.Aug 17 2015, 4:03 PM
Lydia_Pintscher moved this task from monitoring to ready to go on the Wikidata board.Aug 17 2015, 4:41 PM
Lydia_Pintscher added a parent task: T103817: [Epic] version 2 of the quality extensions.Aug 24 2015, 2:20 PM
Ricordisamoa subscribed.Aug 24 2015, 2:27 PM
JanZerebecki added a project: Story.Sep 25 2015, 8:27 PM
Agabi10 subscribed.Oct 12 2015, 2:41 AM
Lydia_Pintscher removed Andreasburmeister as the assignee of this task.Nov 10 2015, 4:18 PM
Pasleim moved this task from DOING to DONE on the Wikibase-Quality board.Nov 14 2016, 4:19 AM
Pasleim moved this task from DONE to DOING on the Wikibase-Quality board.Nov 14 2016, 4:23 AM
Lydia_Pintscher added subscribers: Ivan_A_Krestinin, Lucas_Werkmeister_WMDE.May 10 2017, 2:23 PM
Lucas_Werkmeister_WMDE mentioned this in T102760: [Task] Hooks to keep constraint table up to date..Jun 2 2017, 4:16 PM
Lucas_Werkmeister_WMDE closed subtask T102760: [Task] Hooks to keep constraint table up to date. as Resolved.
Lucas_Werkmeister_WMDE claimed this task.EditedJun 2 2017, 4:36 PM

With https://gerrit.wikimedia.org/r/#/c/349894 and https://gerrit.wikimedia.org/r/#/c/352864, all constraint statements are stored in the constraint table. What’s left to do is to also read them from there.

Here’s a TODO list of all the constraint types that currently exist in templates (sorted by number of constraints, descending), along with tasks/changes for reading them from constraint statements:

I think we’re pretty well on track for reading all constraint types from statements; once that’s deployed, @Ivan_A_Krestinin can do the actual migration.

Ivan_A_Krestinin added a comment.Jun 2 2017, 8:23 PM

I confirm, code for the migration is ready to run. I am waiting for wbcheckconstraints API ready status.

Lucas_Werkmeister_WMDE added a subtask: T167106: Import type and value type constraints from statements.Jun 6 2017, 10:31 AM
Lucas_Werkmeister_WMDE created subtask T167107: Import inverse constraints from statements.Jun 6 2017, 10:35 AM
Lucas_Werkmeister_WMDE created subtask T167108: Import item constraints from statements.
Lucas_Werkmeister_WMDE created subtask T167109: Import target required claim constraints from statements.
Lucas_Werkmeister_WMDE created subtask T167110: Import conflicts with constraints from statements.Jun 6 2017, 10:38 AM
Lucas_Werkmeister_WMDE created subtask T167111: Import one of constraints from statements.
gerritbot subscribed.Jun 6 2017, 10:39 AM

Change 356825 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add some support for somevalue and novalue

https://gerrit.wikimedia.org/r/356825

gerritbot added a project: Patch-For-Review.Jun 6 2017, 10:39 AM
Lucas_Werkmeister_WMDE added a subtask: T167399: Translate constraint type Q-IDs into strings.Jun 8 2017, 10:55 AM
Lucas_Werkmeister_WMDE created subtask T167413: Import range constraints from statements.Jun 8 2017, 1:58 PM
Lucas_Werkmeister_WMDE created subtask T167414: Import diff within range constraints from statements.
Lucas_Werkmeister_WMDE created subtask T167415: Import qualifiers constraints from statements.
Lucas_Werkmeister_WMDE created subtask T167416: Import mandatory qualifiers constraints from statements.Jun 8 2017, 2:00 PM
Lucas_Werkmeister_WMDE created subtask T167417: Import commons link constraints from statements.
Lucas_Werkmeister_WMDE created subtask T167418: Import format constraints from statements.
• Jonas closed subtask T167106: Import type and value type constraints from statements as Resolved.Jun 12 2017, 11:53 AM
Lucas_Werkmeister_WMDE closed subtask T167107: Import inverse constraints from statements as Resolved.Jun 13 2017, 9:50 AM
gerritbot added a comment.Jun 14 2017, 9:23 AM

Change 356825 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add some support for somevalue and novalue

https://gerrit.wikimedia.org/r/356825

Lucas_Werkmeister_WMDE closed subtask T167110: Import conflicts with constraints from statements as Resolved.Jun 14 2017, 9:31 AM
Lucas_Werkmeister_WMDE closed subtask T167109: Import target required claim constraints from statements as Resolved.
Lucas_Werkmeister_WMDE closed subtask T167108: Import item constraints from statements as Resolved.
Lucas_Werkmeister_WMDE closed subtask T167111: Import one of constraints from statements as Resolved.Jun 14 2017, 9:41 AM
Lucas_Werkmeister_WMDE closed subtask T167416: Import mandatory qualifiers constraints from statements as Resolved.Jun 14 2017, 10:18 AM
• Jonas closed subtask T167413: Import range constraints from statements as Resolved.Jun 20 2017, 10:52 AM
• Jonas closed subtask T167415: Import qualifiers constraints from statements as Resolved.
Lucas_Werkmeister_WMDE closed subtask T167414: Import diff within range constraints from statements as Resolved.Jun 22 2017, 12:34 PM
Lucas_Werkmeister_WMDE closed subtask T167417: Import commons link constraints from statements as Resolved.Jun 26 2017, 11:01 AM
Lucas_Werkmeister_WMDE closed subtask T167418: Import format constraints from statements as Resolved.Jun 26 2017, 1:17 PM
Lucas_Werkmeister_WMDE created subtask T169218: Create maintenance script to run constraintsTableUpdate jobs for all properties.Jun 29 2017, 1:35 PM
• Jonas closed subtask T167399: Translate constraint type Q-IDs into strings as Resolved.Jun 30 2017, 12:42 PM
Lucas_Werkmeister_WMDE created subtask T169430: Import constraint exceptions from constraint statements.Jul 1 2017, 12:48 PM
Lucas_Werkmeister_WMDE created subtask T169647: Enable constraint statements on Wikidata.Jul 4 2017, 2:56 PM
Lucas_Werkmeister_WMDE removed a subtask: T169218: Create maintenance script to run constraintsTableUpdate jobs for all properties.Jul 4 2017, 3:15 PM
• Jonas closed subtask T169430: Import constraint exceptions from constraint statements as Resolved.Jul 4 2017, 3:21 PM
gerritbot added a comment.Jul 12 2017, 10:37 AM

Change 364689 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Update special page explanation for constraint statements

https://gerrit.wikimedia.org/r/364689

gerritbot added a comment.Jul 12 2017, 1:43 PM

Change 364689 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Update special page explanation for constraint statements

https://gerrit.wikimedia.org/r/364689

hoo closed subtask T169647: Enable constraint statements on Wikidata as Resolved.Jul 21 2017, 9:58 AM
Lucas_Werkmeister_WMDE reopened subtask T169647: Enable constraint statements on Wikidata as Open.Jul 21 2017, 10:34 AM
hoo closed subtask T169647: Enable constraint statements on Wikidata as Resolved.Jul 21 2017, 10:45 AM
Lucas_Werkmeister_WMDE closed this task as Resolved.Jul 21 2017, 10:53 AM

I think we can close this now, constraint statements are enabled on Wikidata and were also imported from the existing statements.

Restricted Application added a subscriber: PokestarFan. · View Herald TranscriptAug 2 2017, 6:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL