Implement “Units” constraint
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Lucas_Werkmeister_WMDE
	May 3 2017, 2:16 PM

Description

As a data maintainer I want to be able to define which units are allowed for a given property with datatype quantity.
I only want to define the base-unit for a dimension and then automatically all the other derived units are also allowed.

See Template:Constraint:Units: must use one of the listed units (or novalue for no units allowed).

This ought to cover T132704.

Steps:

see README for adding a new constraint type in general
this checker will need some unit resolver thingy injected – see RangeCheckerHelper (because we also want to accept millimetres if the constraint says metres)

Patch-For-Review:

Details

Subject	Repo	Branch	Lines +/-
Move word inside {{PLURAL}} template	mediawiki/extensions/WikibaseQualityConstraints	master	+1 -1
Use wbqc-violation-message-units-none message	mediawiki/extensions/WikibaseQualityConstraints	master	+27 -6
Add missing roles to AllowedUnitsChecker messages	mediawiki/extensions/WikibaseQualityConstraints	master	+4 -4
Add support for parsing units parameter	mediawiki/extensions/WikibaseQualityConstraints	master	+234 -6
Add “allowed units” constraint type	mediawiki/extensions/WikibaseQualityConstraints	master	+457 -0

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T56318 Quantity datatype (tracking)
Resolved	Feature	Michael	T68580 Better support for exact values in Quantity DataType
Resolved		daniel	T140997 When guessing quantity precision from digits, use the +/-0.5 rule rather than the +/-1 rule
Open		None	T133042 Quantity datatype precision (tracking)
Resolved		Lydia_Pintscher	T115269 [Story] When a Quantity is entered with no uncertainty/bounds given, do not guess uncertainty/bounds until needed.
Resolved		thiemowmde	T115270 Allow QuantityValue objects to have empty/no bounds set
Resolved		daniel	T105623 [Task] Investigate quantification of quantity precision (+/- 1 or +/- 0.5)
Open		None	T77977 [Epic] Unit support
Resolved		Lucas_Werkmeister_WMDE	T164372 Implement “Units” constraint
Resolved		Lydia_Pintscher	T142086 [Task] announce quantity changes
Resolved		Ladsgroup	T142087 [Task] prepare bot for quantity change fixes
Open		None	T112247 [RFC] Create a "number" datatype for exact values
Resolved		Ladsgroup	T154168 Quantity changes broke ORES

Event Timeline

Lucas_Werkmeister_WMDE created this task.May 3 2017, 2:16 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 3 2017, 2:16 PM

Lydia_Pintscher triaged this task as High priority.May 5 2017, 12:59 PM

Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.

We might also want to add another constraint, for the base unit of a quantity (kg, s, m, …), accepting any quantity whose conversion to standard units (via UnitConverter) has that base unit as unit.

I suppose this could also be done as the same constraint type with two different kinds of parameters.

Lucas_Werkmeister_WMDE mentioned this in T102759: [Story] Migrate constraints from property talk pages to statements on properties.Jun 2 2017, 4:36 PM

daniel added a parent task: T77977: [Epic] Unit support .Jul 24 2017, 2:16 PM

Restricted Application added a subscriber: PokestarFan. · View Herald TranscriptJul 24 2017, 2:16 PM

Sjoerddebruin awarded a token.Jan 14 2018, 4:06 PM

Sjoerddebruin subscribed.

matej_suchanek awarded a token.Jan 26 2018, 11:02 AM

Lydia_Pintscher updated the task description. (Show Details)Mar 5 2018, 5:27 PM

@Lydia_Pintscher:

I only want to define the base-unit for a dimension and then automatically all the other derived units are also allowed.

That’s a change in behavior from KrBot (for example, P2660 “topographic prominence” has a constraint stating that the unit should be “metre”, and the database report lists lots of items with unit “foot” as violations). Are we sure we want this to be the default behavior?

We just talked about it and it makes sense to have the default be more lenient for now. If needed we can add a parameter to be more strict later.

Lucas_Werkmeister_WMDE added a project: Wikidata-Ministry-Of-Magic.Mar 6 2018, 11:01 AM

Lucas_Werkmeister_WMDE moved this task from Tasks to User Stories on the Wikidata-Ministry-Of-Magic board.Mar 6 2018, 11:10 AM

Lydia_Pintscher moved this task from ready to go to in progress on the Wikidata board.Mar 14 2018, 12:52 PM

Lucas_Werkmeister_WMDE assigned this task to Ladsgroup.Mar 27 2018, 2:13 PM

Lucas_Werkmeister_WMDE updated the task description. (Show Details)

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptMar 27 2018, 2:13 PM

Lucas_Werkmeister_WMDE claimed this task.Apr 4 2018, 10:42 AM

Lucas_Werkmeister_WMDE added a subscriber: Ladsgroup.

Lucas_Werkmeister_WMDE moved this task from User Stories to In Progress on the Wikidata-Ministry-Of-Magic board.Apr 4 2018, 11:41 AM

Change 423972 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add support for parsing units parameter

https://gerrit.wikimedia.org/r/423972

Change 423973 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add “allowed units” constraint type

https://gerrit.wikimedia.org/r/423973

Lucas_Werkmeister_WMDE moved this task from In Progress to Needs Review on the Wikidata-Ministry-Of-Magic board.Apr 4 2018, 4:54 PM

Lydia_Pintscher moved this task from incoming to Features/bugs for next release on the Wikibase-Quality-Constraints board.Apr 6 2018, 4:14 PM

Pintoch awarded a token.Apr 9 2018, 2:42 PM

• Jonas moved this task from Needs Review to In Progress on the Wikidata-Ministry-Of-Magic board.Apr 16 2018, 10:04 AM

Lucas_Werkmeister_WMDE moved this task from In Progress to Needs Review on the Wikidata-Ministry-Of-Magic board.Apr 16 2018, 2:56 PM

I'm not sure if it's a good idea to allow any convertible unit by default.

There are several things that could be improved around quantity datatype and I wouldn't start with this one.

Change 423972 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add support for parsing units parameter

https://gerrit.wikimedia.org/r/423972

Change 423973 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add “allowed units” constraint type

https://gerrit.wikimedia.org/r/423973

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)).Apr 18 2018, 2:00 PM

I’m an idiot, back to “in progress” we go

Change 427391 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add missing roles to AllowedUnitsChecker messages

https://gerrit.wikimedia.org/r/427391

Change 427392 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Use wbqc-violation-message-units-none message

https://gerrit.wikimedia.org/r/427392

Change 427393 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Move word inside {{PLURAL}} template

https://gerrit.wikimedia.org/r/427393

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Apr 18 2018, 2:23 PM

Lucas_Werkmeister_WMDE moved this task from In Progress to Needs Review on the Wikidata-Ministry-Of-Magic board.

Change 427391 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add missing roles to AllowedUnitsChecker messages

https://gerrit.wikimedia.org/r/427391

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Apr 18 2018, 2:54 PM