Page MenuHomePhabricator
Create Task
Maniphest T167898

"Clear styling" gives ⌘M as a keyboard shortcut, but this is Minimize Window in Safari and Firefox on a Mac
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Command-M is listed as a keyboard shortcut to clear styling in the character styles menu. However, it doesn't work, because the browser minimizes the window instead.

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (f2e03ee6f)mediawiki/extensions/VisualEditormaster+1 -1
TriggerRegistry: Remove ⌘+M shortcut for removing styling on MacsVisualEditor/VisualEditormaster+1 -2
Customize query in gerrit

Related Objects

Event Timeline

• Whatamidoing-WMF created this task.Jun 14 2017, 4:35 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 14 2017, 4:35 PM
• Esanders subscribed.Jun 14 2017, 4:57 PM

And Chrome?

• Whatamidoing-WMF added a comment.Jun 14 2017, 9:51 PM

I don't know; I've never used Chrome.

• Deskana subscribed.Jun 15 2017, 1:33 PM
In T167898#3348780, @Esanders wrote:

And Chrome?

This is an OS-level shortcut, so the same thing happens in Chrome.

There is already ⌘+\ as another shortcut for removing styling so maybe we should just remove the ⌘+M shortcut.

gerritbot subscribed.Jun 16 2017, 3:21 PM

Change 359455 had a related patch set uploaded (by Deskana; owner: Deskana):
[VisualEditor/VisualEditor@master] Remove ⌘ M shortcut for removing styling on mavs

https://gerrit.wikimedia.org/r/359455

gerritbot added a project: Patch-For-Review.Jun 16 2017, 3:21 PM
• Deskana added a comment.Jun 16 2017, 3:21 PM

We should get rid of this shortcut. ⌘+M overrides the minimisation of the window if there's styling to remove, which is a bad interaction pattern.

• Deskana triaged this task as Medium priority.Jun 16 2017, 3:23 PM
• Deskana moved this task from To Triage to TR1: Releases on the VisualEditor board.
gerritbot added a comment.Jun 16 2017, 3:30 PM

Change 359455 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] TriggerRegistry: Remove ⌘ M shortcut for removing styling on Macs

https://gerrit.wikimedia.org/r/359455

• Deskana closed this task as Resolved.Jun 16 2017, 3:31 PM
• Deskana claimed this task.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJun 16 2017, 3:31 PM
gerritbot added a comment.Jun 16 2017, 3:39 PM

Change 359456 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (f2e03ee6f)

https://gerrit.wikimedia.org/r/359456

gerritbot added a comment.Jun 16 2017, 10:20 PM

Change 359456 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (f2e03ee6f)

https://gerrit.wikimedia.org/r/359456

Jdforrester-WMF edited projects, added VisualEditor-EditingTools; removed Patch-For-Review.Jun 16 2017, 10:27 PM
Jdforrester-WMF set the point value for this task to 1.
ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-06-20_(1.30.0-wmf.6)).Jun 16 2017, 11:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits