Page MenuHomePhabricator

"Clear styling" gives ⌘M as a keyboard shortcut, but this is Minimize Window in Safari and Firefox on a Mac
Closed, ResolvedPublic1 Estimated Story Points

Description

Command-M is listed as a keyboard shortcut to clear styling in the character styles menu. However, it doesn't work, because the browser minimizes the window instead.

Event Timeline

I don't know; I've never used Chrome.

And Chrome?

This is an OS-level shortcut, so the same thing happens in Chrome.

There is already ⌘+\ as another shortcut for removing styling so maybe we should just remove the ⌘+M shortcut.

Change 359455 had a related patch set uploaded (by Deskana; owner: Deskana):
[VisualEditor/VisualEditor@master] Remove ⌘ M shortcut for removing styling on mavs

https://gerrit.wikimedia.org/r/359455

We should get rid of this shortcut. ⌘+M overrides the minimisation of the window if there's styling to remove, which is a bad interaction pattern.

Deskana triaged this task as Medium priority.Jun 16 2017, 3:23 PM
Deskana moved this task from To Triage to TR1: Releases on the VisualEditor board.

Change 359455 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] TriggerRegistry: Remove ⌘ M shortcut for removing styling on Macs

https://gerrit.wikimedia.org/r/359455

Deskana claimed this task.

Change 359456 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (f2e03ee6f)

https://gerrit.wikimedia.org/r/359456

Change 359456 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (f2e03ee6f)

https://gerrit.wikimedia.org/r/359456