Some of Refreshed's stylesheets no longer apply after upgrade to MW 1.25 or later
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	Jun 16 2017, 7:30 PM

Description

Some of Refreshed's stylesheets defined in ResourceModuleSkinStyles no longer apply after upgrade to MW 1.25 or later. @ashley complained about this on IRC but he's too lazy to file a bug.

Details

	Subject	Repo	Branch	Lines +/-
	ResourceLoaderSkinModule: Fix SkinStyles extending of known media queries	mediawiki/core	master	+17 -0
	Allow $wgResourceModuleSkinStyles for any ResourceLoaderFileModule subclass	mediawiki/core	master	+8 -5

Customize query in gerrit

Event Timeline

matmarex created this task.Jun 16 2017, 7:30 PM

matmarex added a project: MediaWiki-ResourceLoader.

Change 357327 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] Allow $wgResourceModuleSkinStyles for any ResourceLoaderFileModule subclass

https://gerrit.wikimedia.org/r/357327

Change 359503 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] ResourceLoaderSkinModule: Do not fail for specific media queries

https://gerrit.wikimedia.org/r/359503

Change 357327 merged by jenkins-bot:
[mediawiki/core@master] Allow $wgResourceModuleSkinStyles for any ResourceLoaderFileModule subclass

https://gerrit.wikimedia.org/r/357327

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)).Jun 21 2017, 8:00 PM

So, is this now fixed?

No, the other patch needs to be merged.

Krinkle triaged this task as High priority.Jul 8 2017, 2:44 AM

Krinkle moved this task from Inbox to Confirmed Problem on the MediaWiki-ResourceLoader board.

Change 359503 merged by jenkins-bot:
[mediawiki/core@master] ResourceLoaderSkinModule: Fix SkinStyles extending of known media queries

https://gerrit.wikimedia.org/r/359503

matmarex closed this task as Resolved.Jul 10 2017, 6:42 PM

matmarex claimed this task.

matmarex removed a project: Patch-For-Review.

ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)); removed MW-1.30-release-notes (WMF-deploy-2017-06-27_(1.30.0-wmf.7)).Jul 10 2017, 7:00 PM

Some of Refreshed's stylesheets no longer apply after upgrade to MW 1.25 or laterClosed, ResolvedPublicActions

Description

Details

Event Timeline

Some of Refreshed's stylesheets no longer apply after upgrade to MW 1.25 or later
Closed, ResolvedPublic
Actions