Page MenuHomePhabricator

Some of Refreshed's stylesheets no longer apply after upgrade to MW 1.25 or later
Closed, ResolvedPublic

Description

Some of Refreshed's stylesheets defined in ResourceModuleSkinStyles no longer apply after upgrade to MW 1.25 or later. @ashley complained about this on IRC but he's too lazy to file a bug.

Event Timeline

Change 357327 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] Allow $wgResourceModuleSkinStyles for any ResourceLoaderFileModule subclass

https://gerrit.wikimedia.org/r/357327

Change 359503 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] ResourceLoaderSkinModule: Do not fail for specific media queries

https://gerrit.wikimedia.org/r/359503

Change 357327 merged by jenkins-bot:
[mediawiki/core@master] Allow $wgResourceModuleSkinStyles for any ResourceLoaderFileModule subclass

https://gerrit.wikimedia.org/r/357327

So, is this now fixed?

No, the other patch needs to be merged.

Krinkle triaged this task as High priority.Jul 8 2017, 2:44 AM
Krinkle moved this task from Inbox to Accepted: Bugs on the MediaWiki-ResourceLoader board.

Change 359503 merged by jenkins-bot:
[mediawiki/core@master] ResourceLoaderSkinModule: Fix SkinStyles extending of known media queries

https://gerrit.wikimedia.org/r/359503

matmarex closed this task as Resolved.Jul 10 2017, 6:42 PM
matmarex claimed this task.
matmarex removed a project: Patch-For-Review.