Page MenuHomePhabricator

"Group changes by page in recent changes and watchlist" and "Show Wikidata edits in recent changes" don't work when you use the New filters for edit review Beta feature
Closed, InvalidPublic

Description

I use with my volunteer account to make the following tests. I use safemode=1, just in case of a conflict with another gadget/script.

I have enabled "Show Wikidata edits in recent changes"
I have enabled "New filters for edit review"

When I go to the RCs, I have this configuration of filters:

Capture d’écran_2017-06-22_16-45-36.png (115×1 px, 13 KB)

I see Wikidata edits.

I go then to my preferences, and enable "Group changes by page in recent changes and watchlist"
I go back to the RC page and reload it.
I have the following filters:

Capture d’écran_2017-06-22_16-47-45.png (110×1 px, 11 KB)

The edits are all grouped. I don't have any Wikidata edits visible.

I've made an edit on Wikidata in the case there is zero edits when I test. The edit is done on the article "Théâtre universitaire de Strasbourg" (at the bottom of the next screenshot)
I've reloaded the page and I still don't have the Wikidata edit.

Capture d’écran_2017-06-22_16-52-23.png (704×1 px, 296 KB)

When I disable "Group changes by page in recent changes and watchlist", the Wikidata edit is visible now in the RC page.

Capture d’écran_2017-06-22_16-53-55.png (143×1 px, 86 KB)

Event Timeline

@Trizek-WMF - please take a look if the fix addresses the issue you've reported.

The patch https://gerrit.wikimedia.org/r/#/c/355799/ fixed the issue (in wmf.7).

Now, Preferences-Recent changes does not have a restriction that Wikidata box should unchecked (the previous wording: "Group changes by page in recent changes and watchlist (de-activate for the "Show Wikidata" option below to work" ).
When settings are set like that (according to your steps in the tickets)

Screen Shot 2017-07-03 at 3.53.46 PM.png (177×654 px, 29 KB)

Recent changes page will display Wikidata entries (in uncollapsed and collapsed view) along with other edits. The selection of the Wikidata filter along with other default filters after enabling is preserved too.

Screen Shot 2017-07-03 at 3.51.26 PM.png (576×1 px, 213 KB)

My bad, I've reported this bug on a wiki where the feature was not deployed yet.