Page MenuHomePhabricator
Create Task
Maniphest T16899

When __INDEX__ and __NOINDEX__ both occur, the last one in the source should win
Closed, DeclinedPublic
Actions

Description

Author: ayg

Description:
Currently (r37973) when INDEX and NOINDEX both occur on the page, the page is indexable, regardless of the order or the number of times they appear. This is because in line 3386 of Parser.php, I only check whether $this->mDoubleUnderscores has the appropriate indexes. By this point we don't know which one came first. It wasn't immediately obvious to me how best to fix it -- how do NOTOC and FORCETOC work? It's not a big thing, so I figured it didn't need to block the new feature.

Version: unspecified
Severity: minor

Details

Reference
bz14899

Event Timeline

• bzimport raised the priority of this task from to Lowest.Nov 21 2014, 10:13 PM
• bzimport added a project: MediaWiki-General.
• bzimport set Reference to bz14899.
• bzimport added a subscriber: Unknown Object (MLST).
• bzimport created this task.Jul 23 2008, 7:58 PM
tstarling added a comment.Jul 25 2008, 11:01 AM

I'm not sure why you think this is worth doing. The resulting code would be quite a bit more complicated.

• bzimport added a comment.Jul 25 2008, 2:03 PM

ayg wrote:

It seems to me that the current way of doing it is less intuitive. I would certainly expect the last one in the page to win. If it's complicated to do this with our current setup (and you would know that better than I), I guess it's not worth doing in the foreseeable future.

It seems NOTOC and FORCETOC work the same, at a glance, with FORCETOC always overriding NOTOC. It would be nice if some mechanism could be added to get this to work more nicely, but there are probably better things to do, yeah. Don't see any reason to close the bug, though.

MarkAHershberger subscribed.Aug 20 2015, 6:57 PM

Why is there even an INDEX ?

Danny_B removed a subtask: T10068: Magic word to add noindex to a page's header.Jul 25 2016, 12:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL