Page MenuHomePhabricator
Create Task
Maniphest T169121

Add tests for ConstraintParameterRenderer
Closed, ResolvedPublic
Actions

Description

As Thiemo pointed out in I32050f, the change neglected to add any tests. Currently, ConstraintParameterRenderer doesn’t have any tests…

I won’t do this right now, since constraint statements are higher priority.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Rewrite ConstraintParameterRendererTest::assertConstraintReportParameterListmediawiki/extensions/WikibaseQualityConstraintsmaster+8 -6
Extract ConstraintParameterRendererTest::assertConstraintReportParameterListmediawiki/extensions/WikibaseQualityConstraintsmaster+34 -113
Add tests for ConstraintParameterRenderermediawiki/extensions/WikibaseQualityConstraintsmaster+654 -0
Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
OpenNoneT167127 Standard UI for including statements in constraint violation messages
ResolvedLucas_Werkmeister_WMDET169121 Add tests for ConstraintParameterRenderer
· · ·

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jun 28 2017, 5:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 28 2017, 5:29 PM
Lucas_Werkmeister_WMDE added a project: Wikidata-Sprint-2018-01-17.Jan 22 2018, 12:41 PM
Lucas_Werkmeister_WMDE moved this task from incoming to in progress on the Wikidata board.
Lucas_Werkmeister_WMDE moved this task from Backlog to In Progress on the Wikidata-Sprint-2018-01-17 board.
gerritbot subscribed.Jan 22 2018, 2:52 PM

Change 405721 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add tests for ConstraintParameterRenderer

https://gerrit.wikimedia.org/r/405721

gerritbot added a project: Patch-For-Review.Jan 22 2018, 2:52 PM
Lucas_Werkmeister_WMDE moved this task from In Progress to Review on the Wikidata-Sprint-2018-01-17 board.Jan 22 2018, 2:52 PM
Lucas_Werkmeister_WMDE renamed this task from Add tests for constraint parameter roles to Add tests for ConstraintParameterRenderer.Jan 22 2018, 3:35 PM
gerritbot added a comment.Jan 23 2018, 1:09 PM

Change 405872 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Extract ConstraintParameterRendererTest::assertConstraintReportParameterList

https://gerrit.wikimedia.org/r/405872

gerritbot added a comment.Jan 23 2018, 1:18 PM

Change 405721 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add tests for ConstraintParameterRenderer

https://gerrit.wikimedia.org/r/405721

Ladsgroup moved this task from Review to Done on the Wikidata-Sprint-2018-01-17 board.Jan 23 2018, 1:31 PM
gerritbot added a comment.Jan 23 2018, 1:40 PM

Change 405872 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Extract ConstraintParameterRendererTest::assertConstraintReportParameterList

https://gerrit.wikimedia.org/r/405872

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-06 (1.31.0-wmf.20)).Jan 23 2018, 2:00 PM
gerritbot added a comment.Jan 23 2018, 2:35 PM

Change 405877 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Rewrite ConstraintParameterRendererTest::assertConstraintReportParameterList

https://gerrit.wikimedia.org/r/405877

gerritbot added a comment.Jan 23 2018, 2:49 PM

Change 405877 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Rewrite ConstraintParameterRendererTest::assertConstraintReportParameterList

https://gerrit.wikimedia.org/r/405877

Lucas_Werkmeister_WMDE closed this task as Resolved.Jan 30 2018, 12:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits