Page MenuHomePhabricator
Create Task
Maniphest T169258

Core tests depend on TimedMediaHandler
Closed, ResolvedPublic
Actions

Description

In core, we have class MockOggHandler extends OggHandlerTMH while OggHandlerTMH is from TimedMediaHandler. Core should not depend on extensions.

Details

SubjectRepoBranchLines +/-
Remove test code that depends on extensionmediawiki/coremaster+35 -163
Add MockOggHandler and reenable TMH parser testsmediawiki/extensions/TimedMediaHandlermaster+110 -3
Temporarily disable TimedMediaHandler parser testsmediawiki/extensions/TimedMediaHandlermaster+2 -1
Customize query in gerrit

Event Timeline

MaxSem created this task.Jun 29 2017, 6:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 29 2017, 6:33 PM
Krinkle moved this task from Inbox to PHPUnit on the MediaWiki-Core-Tests board.Jul 7 2017, 5:19 AM
TheDJ subscribed.Jul 7 2017, 11:42 AM

i'm pretty sure there is another ticket on this exact topic, but i cannot find it.

MarkTraceur triaged this task as Medium priority.Jul 10 2017, 3:07 PM
MarkTraceur moved this task from Untriaged to Next up on the Multimedia board.
gerritbot subscribed.Jul 11 2017, 2:36 PM

Change 364446 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/core@master] [WIP] Remove tests depending on extension

https://gerrit.wikimedia.org/r/364446

gerritbot added a project: Patch-For-Review.Jul 11 2017, 2:36 PM
gerritbot added a comment.Jul 12 2017, 3:01 PM

Change 364747 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/TimedMediaHandler@master] Temporarily disable TimedMediaHandler parser tests

https://gerrit.wikimedia.org/r/364747

gerritbot added a comment.Jul 12 2017, 3:12 PM

Change 364751 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/TimedMediaHandler@master] Add MockOggHandler and reenable parser tests

https://gerrit.wikimedia.org/r/364751

matthiasmullie claimed this task.Jul 12 2017, 3:53 PM
matthiasmullie moved this task from Next up to Needs code review on the Multimedia board.
gerritbot added a comment.Aug 13 2017, 4:20 PM

Change 364747 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Temporarily disable TimedMediaHandler parser tests

https://gerrit.wikimedia.org/r/364747

gerritbot added a comment.Aug 13 2017, 4:35 PM

Change 364446 merged by jenkins-bot:
[mediawiki/core@master] Remove test code that depends on extension

https://gerrit.wikimedia.org/r/364446

gerritbot added a comment.Aug 13 2017, 4:48 PM

Change 364751 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Add MockOggHandler and reenable TMH parser tests

https://gerrit.wikimedia.org/r/364751

• brion closed this task as Resolved.Aug 13 2017, 4:55 PM
• brion subscribed.

We managed to merge these; MockOggHandler now lives in TMH. :D

ReleaseTaggerBot added a project: MW-1.30-release-notes.Aug 21 2017, 5:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL