Minerva should not need MobileFrontend for MobileUI - move mediawiki abstractions into core
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Jul 3 2017, 6:04 PM

Description

MobileFrontend provides the MobileUI class (https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/includes/MobileUI.php) which provides helpers for rendering mediawiki ui components.

It uses it, but Minerva also needs access to it to support a desktop skin.

OOjs UI is not an option in Minerva at the moment. This is too much work and would have negative consequences on first paint - the Minerva skin only needs to render buttons and icons... no other widgets.

Options

MobileUI should live in core and be renamed MediaWikiUI
We copy and paste MobileUI into Minerva and rename to MinervaUI

Details

	Subject	Repo	Branch	Lines +/-
	Prepare to break the server side MobileFrontend dependency on Minerva	mediawiki/skins/MinervaNeue	master	+186 -24

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Jdlrobson	T195473 [GOAL] Invest in the MobileFrontend & MinervaNeue frontend architecture
Resolved	Jdlrobson	T171000 [EPIC] Minerva works independently of MobileFrontend
Resolved	Jdlrobson	T169569 Minerva should not need MobileFrontend for MobileUI - move mediawiki abstractions into core

Event Timeline

Jdlrobson created this task.Jul 3 2017, 6:04 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 3 2017, 6:04 PM

Jdlrobson mentioned this in T166915: Create an abstraction for the message box components (warningbox, errorbox etc).Jul 3 2017, 6:04 PM

Jdlrobson added a parent task: T171000: [EPIC] Minerva works independently of MobileFrontend.Jul 18 2017, 10:38 PM

Jdlrobson updated the task description. (Show Details)

Hey Moriel - this was the issue I just spoke to you about in the corridor :)
I think this would be a good intermediate step for porting lots of extensions over to OOjs UI who don't have the capacity to port all their code to OOjs UI for whatever reasons.

Jdlrobson added a project: Web-Team-Backlog.Jul 18 2017, 11:15 PM

Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.

Jdlrobson edited projects, added Web-Team-Backlog (Tracking); removed Web-Team-Backlog.Jul 19 2017, 3:38 PM

Jdlrobson moved this task from Untriaged to Discuss further on the Web-Team-Backlog (Tracking) board.Jul 21 2017, 7:12 PM

Change 372186 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Prepare to break the server side MobileFrontend dependency on Minerva

https://gerrit.wikimedia.org/r/372186

gerritbot added a project: Patch-For-Review.Sep 27 2017, 9:22 PM

Change 372186 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Prepare to break the server side MobileFrontend dependency on Minerva

https://gerrit.wikimedia.org/r/372186

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)).Sep 27 2017, 10:00 PM