Page MenuHomePhabricator

Minerva should not need MobileFrontend for MobileUI - move mediawiki abstractions into core
Closed, ResolvedPublic

Description

MobileFrontend provides the MobileUI class (https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/includes/MobileUI.php) which provides helpers for rendering mediawiki ui components.

It uses it, but Minerva also needs access to it to support a desktop skin.

OOjs UI is not an option in Minerva at the moment. This is too much work and would have negative consequences on first paint - the Minerva skin only needs to render buttons and icons... no other widgets.

Options

  • MobileUI should live in core and be renamed MediaWikiUI
  • We copy and paste MobileUI into Minerva and rename to MinervaUI

Event Timeline

Jdlrobson created this task.Jul 3 2017, 6:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 3 2017, 6:04 PM

Hey Moriel - this was the issue I just spoke to you about in the corridor :)
I think this would be a good intermediate step for porting lots of extensions over to OOjs UI who don't have the capacity to port all their code to OOjs UI for whatever reasons.

Change 372186 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Prepare to break the server side MobileFrontend dependency on Minerva

https://gerrit.wikimedia.org/r/372186

Change 372186 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Prepare to break the server side MobileFrontend dependency on Minerva

https://gerrit.wikimedia.org/r/372186