Html class seems a good place for this to live?

+1

We have abstractions in MobileFrontend:
https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/includes/MobileUI.php

Annoyingly we are copy/pasting these into other extensions now (see T169569)
Maybe it's time to put that in core?

Not exactly the same, but there are warning and errorboxes in OOUI too. See the FieldLayout with error message for example. These are tied to a single form element, not the entire form. Are we looking at both?

Change 381291 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Provide message/warning/error box abstraction

https://gerrit.wikimedia.org/r/381291

Patch is up ^ I'd appreciate some thoughts particularly about:

1. How to handle those wrapWikiMsg usages
2. Whether we should allow additional ids and classes on the first path standardised message/warning/success boxes.

Feedback appreciated @Esanders and @Volker_E
There is some feedback from @Legoktm and I am fine with that (although it creates more work for me), but I want to check we're okay with the proposal before continuing.

I've responded to the feedback and am waiting for another round of review.

@Jdlrobson Just saw the comment about “additional ids and classes on the first path standardised”
What do you mean by first path and what use cases to you have in mind?

additional ids and classes on the first path standardised”

What I meant was there are some cases where warningbox class is also accompanied by other classes and an id. I'm not sure we want to encourage that so I've purposely not made that possible in the first "pass" of standardisation.

Change 381291 merged by jenkins-bot:
[mediawiki/core@master] Provide message/warning/error box abstraction

https://gerrit.wikimedia.org/r/381291

Change 391626 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Add unit tests for Html helper methods and change messageBox visibility

https://gerrit.wikimedia.org/r/391626

Change 391626 merged by jenkins-bot:
[mediawiki/core@master] Add unit tests for Html helper methods and change messageBox visibility

https://gerrit.wikimedia.org/r/391626

This is a great idea but IMO we should be vary of making Html the grab-bag utility class of all things that generate HTML. Maybe there should be a WikimediaUI or similar class for generating HTML for a specific design style, and Html should be preserved for methods which take an exact specification of HTML code in some structured form and turn it into a string? (Yeah I know I'm a little late raising this issue.)

Yeh that was the original hope, but OOUI is basically this and that's why it's not happened. The problem is OOUI adoption is much harder than using PHP helper methods in a lot of places in our codebase.

In fact we have one in both MobileFrontend and Minerva:

• https://github.com/wikimedia/mediawiki-extensions-MobileFrontend/blob/master/includes/MobileUI.php
• https://github.com/wikimedia/mediawiki-skins-MinervaNeue/blob/master/includes/MinervaUI.php

When I've tried to upstream this I've encountered much apathy so would happily review patches that split out the functionality from Html into a separate MediaWiki class.