Improve styling of the non-js editor in mobile so the form is usable
Closed, ResolvedPublic0 Estimated Story Points
Actions

Assigned To

Authored By

	Jdlrobson
	Jul 5 2017, 6:16 PM

Description

Non-js editing was just enabled on Ptwiki (https://gerrit.wikimedia.org/r/361455) but it looking terribly cluttered and not very usable.

Screen Shot 2017-07-05 at 11.13.36 AM.png (957×464 px, 100 KB)

Screen Shot 2017-07-05 at 11.13.41 AM.png (891×452 px, 160 KB)

Please

Change the font size of the text at the top of the page (include it in the .action-submit .preview-limit-report-wrapper, .action-edit .preview-limit-report-wrapper, .action-submit .diff-otitle, .action-edit .diff-otitle, .action-submit .diff-ntitle, .action-edit .diff-ntitle, .action-submit #section_0, .action-edit #section_0, .action-submit #editpage-copywarn, .action-edit #editpage-copywarn, .action-submit #mw-anon-edit-warning, .action-edit #mw-anon-edit-warning css rule?)
Reconsider displaying .mw-editTools or at least make it less in-your-face.

Details

	Subject	Repo	Branch	Lines +/-
	Minor modifications to core editing elements in non-js mode	mediawiki/extensions/MobileFrontend	master	+11 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Jdforrester-WMF	T125174 [EPIC] Enable editing for mobile users without JavaScript and kill Special:MobileEditor code in MobileFrontend
		Resolved		Jdlrobson	T169784 Improve styling of the non-js editor in mobile so the form is usable

Event Timeline

Jdlrobson created this task.Jul 5 2017, 6:16 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 5 2017, 6:16 PM

Jdlrobson added a parent task: T125174: [EPIC] Enable editing for mobile users without JavaScript and kill Special:MobileEditor code in MobileFrontend.Jul 5 2017, 6:16 PM

Including the other elements in the #mw-anon-edit-warning css rule and adding some specific styles to the top "warning" box results in:

Screen Shot 2017-07-05 at 11.26.38 AM.png (933×704 px, 121 KB)

but it still looks badly designed.
This looks terribly broken and unprofessional in current form.
We can do better @Niharika and @Jdforrester-WMF ...

I'm minded to decline these kind of changes in general. Ultimately if the community want this to look terrible, that's how it's going to appear. Trying to hack code around community-maintained interface content is just a race to the bottom; normally, we ask the community to reconsider their choices.

This is not community maintained content.

The edit notice is provided by core:
https://github.com/wikimedia/mediawiki/blob/master/includes/Title.php#L4846

As are edit-tools
https://github.com/wikimedia/mediawiki/blob/master/includes/htmlform/fields/HTMLEditTools.php#L26

The mobile editor is not styling either correctly. I'm writing a patch...

Change 363643 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Minor modifications to core editing elements in non-js mode

https://gerrit.wikimedia.org/r/363643

gerritbot added a project: Patch-For-Review.Jul 6 2017, 6:35 PM

Change 363643 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Minor modifications to core editing elements in non-js mode

https://gerrit.wikimedia.org/r/363643

So the remaining part seems to be a non-style-guide conforming warning message coming from the community. @Jdlrobson Resolve what we could resolve?

Yes I think the remaining work involves T166915 and T127405

I've had a go at communicating the change by the edit button in good faith:
https://pt.wikipedia.org/wiki/MediaWiki:Editnotice-0

I'm hoping that will be seen as an improvement. If not we'll at least know a little more and have the starting point of a conversation.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJul 7 2017, 11:37 PM

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)).Jul 8 2017, 4:01 AM

Jdforrester-WMF set the point value for this task to 0.Jul 10 2017, 11:12 PM

Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.

Jdforrester-WMF removed a project: Patch-For-Review.

	F8625400: Screen Shot 2017-07-05 at 11.26.38 AM.png
	Jul 5 2017, 6:28 PM

	F8625331: Screen Shot 2017-07-05 at 11.13.41 AM.png
	Jul 5 2017, 6:16 PM

	F8625330: Screen Shot 2017-07-05 at 11.13.36 AM.png
	Jul 5 2017, 6:16 PM

Improve styling of the non-js editor in mobile so the form is usableClosed, ResolvedPublic0 Estimated Story PointsActions

Description

Details

Related ObjectsSearch...

Event Timeline

Improve styling of the non-js editor in mobile so the form is usable
Closed, ResolvedPublic0 Estimated Story Points
Actions

Related Objects
Search...