Increase sampling rate of page previews to 1% on ruwiki, huwiki, itwiki
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ovasileva
	Jul 21 2017, 4:55 PM

Description

background

We need more data for page previews, to complete T158172 in a timely manner

acceptance criteria

Increase sampling rate of the Popups schema to 1% of sessions

Details

	Subject	Repo	Branch	Lines +/-
	pagePreviews: Increase i13n sampling rate for ruwiki	operations/mediawiki-config	master	+1 -1
	pagePreviews: Increase instrumentation sampling rate	operations/mediawiki-config	master	+10 -0

Customize query in gerrit

Related Objects

Mentioned Here: T158172: Analyze results of stage 0 page previews test

Event Timeline

ovasileva created this task.Jul 21 2017, 4:55 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 21 2017, 4:55 PM

ovasileva triaged this task as Unbreak Now! priority.Jul 21 2017, 4:55 PM

Restricted Application added subscribers: Liuxinyu970226, Jay8g, TerraCodes. · View Herald TranscriptJul 21 2017, 4:55 PM

Cf. https://phabricator.wikimedia.org/T158172#3460860

Don't use UBN unless something serious is broken. Lots of people are specifically watching Phabricator for UBN. This is not appropriate usage.

For context:

From https://meta.wikimedia.org/wiki/Schema_talk:Popups , "Per 343675, the sampling rate is current [April 20] 0.1% of all distinct browser sessions."
I hope that statement is still valid after https://gerrit.wikimedia.org/r/#/c/358957/ (June 14).
In any case, per https://grafana.wikimedia.org/dashboard/db/eventlogging-schema?var-schema=Popups , the schema's maximum event rate is currently about 1 event per second. 10 events/second will still be OK. Ideally it would be even higher (we've had working schemas with up to 100 / second), enabling us to complete T158172 with less days of data and/or for smaller wikis, but that would require double-checking with the Analytics Engineering team first.

ovasileva moved this task from To Do to Needs Design Review on the Readers-Web-Kanbanana-Board-Old board.Jul 21 2017, 5:17 PM

• Tbayer updated the task description. (Show Details)Jul 21 2017, 5:17 PM

ovasileva moved this task from Incoming to 2017-18 Q1 on the Web-Team-Backlog board.Jul 21 2017, 5:19 PM

(this is unplanned - see email "Sampling rate for page previews too low" and blocked since no deployments till Monday).

Change 366882 had a related patch set uploaded (by Phuedx; owner: Phuedx):
[operations/mediawiki-config@master] pagePreviews: Increase instrumentation sampling rate

https://gerrit.wikimedia.org/r/366882

gerritbot added a project: Patch-For-Review.Jul 21 2017, 6:06 PM

I can get the above deployed on Monday (24th July) during the European Mid-day SWAT deployment.

phuedx claimed this task.Jul 21 2017, 6:07 PM

Scheduled.

Liuxinyu970226 added a project: Russian-Sites.Jul 22 2017, 12:22 AM

phuedx moved this task from Blocked on Others to Doing on the Readers-Web-Kanbanana-Board-Old board.Jul 24 2017, 1:00 PM

Change 366882 merged by jenkins-bot:
[operations/mediawiki-config@master] pagePreviews: Increase instrumentation sampling rate

https://gerrit.wikimedia.org/r/366882

Mentioned in SAL (#wikimedia-operations) [2017-07-24T13:23:45Z] <zfilipin@tin> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:366882|pagePreviews: Increase instrumentation sampling rate (T171325)]] (duration: 00m 43s)

Change 367398 had a related patch set uploaded (by Phuedx; owner: Phuedx):
[operations/mediawiki-config@master] pagePreviews: Increase i13n sampling rate for ruwiki

https://gerrit.wikimedia.org/r/367398

Change 367398 merged by jenkins-bot:
[operations/mediawiki-config@master] pagePreviews: Increase i13n sampling rate for ruwiki

https://gerrit.wikimedia.org/r/367398

Mentioned in SAL (#wikimedia-operations) [2017-07-24T14:03:57Z] <zfilipin@tin> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:367398|pagePreviews: Increase i13n sampling rate for ruwiki (T171325)]] (duration: 00m 43s)