Page MenuHomePhabricator

Map detail pane displays incorrect coordinates (greater than 180°)
Closed, ResolvedPublic

Description

If the Kartographer map is dragged beyond 180° E/W, then the degree of longitude displayed in the map details pane (top right) becomes higher than 180° instead of being (((longitude + 180°) mod 360°) − 180°).

map_coordinates_not_good_maths.jpg (625×779 px, 371 KB)

Event Timeline

debt renamed this task from Kartographer displays incorrect coordinates to Map detail pane displays incorrect coordinates (greater than 180°).Jul 24 2017, 7:58 PM
debt triaged this task as High priority.
debt added a project: Maps-Sprint.
debt updated the task description. (Show Details)
Pnorman moved this task from Backlog to To-do on the Maps-Sprint board.
Pnorman added a subscriber: Pnorman.

Change 371740 had a related patch set uploaded (by TheDJ; owner: TheDJ):
[mediawiki/extensions/Kartographer@master] Wrap the coordinates on the map when we retrieve them

https://gerrit.wikimedia.org/r/371740

Change 371740 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Wrap the coordinates on the map when we retrieve them

https://gerrit.wikimedia.org/r/371740

TheDJ removed a project: Patch-For-Review.
TheDJ moved this task from To-do to Done on the Maps-Sprint board.
TheDJ added a subscriber: debt.

Hi @Gehel, this will need to be deployed, just a heads up. @TheDJ fixed it during the Hackathon in Montreal. :)

Yep, there is still a train! I still don't know exactly how the magic works, but it should just work :)

Coolio—I had been expecting that the bot was going to tag this with the train it'll ride.