Even though CI is now set up correctly with the wikistats repo, the build is failing in Jenkins because of a series of import errors when generating the js bundle. Check out the build log:
https://integration.wikimedia.org/ci/job/phabricator-jessie-commits/639/console
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • fdans | T171599 Fix Wikistats build in Jenkins | |||
| Resolved | hashar | T161861 Jobs with Node 6 should also have npm 3 | |||
| Resolved | hashar | T172094 npm 3 requires peer dependencies to be explicitly defined in package.json |
Hi @hashar I suspect this is happening because the npm version installed in the Jenkins machine is npm2, and I believe we require npm3 for webpack, and peer dependencies to work correctly. Is it possible for you to upgrade the version? :)
Indeed we are still using npm 2 and havent bothered yet to upgrade to 3 or later. That is the subject of T161861 which regained attention recently.
I am most probably going to upgrade npm to version 3 this Tuesday. The blocker was to explicitly define the peer dependencies and I think I have covered them for most of the repositories (T172094).
We now have npm 3.8.3 (the version that came with nodejs 6.0). I have rebuild the job:
https://integration.wikimedia.org/ci/job/phabricator-jessie-commits/660/console
Looks like it managed to install something :)
It did thank you. Our tests are failing cause it looks like a module is missing (cc @fdans )
PhantomJS 2.1.1 (Linux 0.0.0) ERROR
16:02:37 Error: Cannot find module "../../../semantic/src/definitions/modules/modal"
16:02:37 at test/Dashboard.spec.js:31999
@hashar thank you so much! I've changed a couple of wrong calls to semantic that I added some time ago and now the build is running the tests and passing, so we're done here :)