Page MenuHomePhabricator

New Contributions DateInputWidget doesn't do anything when you click on a month
Closed, ResolvedPublic

Description

Expected behavior: Select a month and then the menu would select the first day of the month
Actual behavior: Select a month and then nothing happens

Steps to reproduce:

  1. Go to https://en.wikipedia.org/wiki/Special:Contributions/EpochFail
  2. Click on the field for "From date"
  3. Click the up arrow "^"
  4. Click "September"

Nothing happens!!!

Details

Related Gerrit Patches:

Event Timeline

Halfak created this task.Jul 29 2017, 3:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 29 2017, 3:56 PM

Actually, something happens, the "To date" field gets focussed. This leads me to believe this is probably a bug from https://gerrit.wikimedia.org/r/#/c/364914/.

To be more precise, I think it's a regression from my response to @Prtksxna's comment on the patch underneath that one: https://gerrit.wikimedia.org/r/#/c/364909/1..2/resources/src/mediawiki.widgets/mw.widgets.DateInputWidget.js . I didn't realize month selection was available even when { precision: 'month' } was not set.

Catrope claimed this task.Jul 31 2017, 7:22 PM

Change 368836 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@master] Follow-up b446a3b9: don't auto-close DateInputWidget too early

https://gerrit.wikimedia.org/r/368836

Change 368836 merged by jenkins-bot:
[mediawiki/core@master] Follow-up b446a3b9: don't auto-close DateInputWidget too early

https://gerrit.wikimedia.org/r/368836

Jdforrester-WMF closed this task as Resolved.Jul 31 2017, 9:12 PM
Jdforrester-WMF edited projects, added Contributors-Team; removed Patch-For-Review, OOUI.