The timecorrection preference on Special:GlobalPreferences currently doesn't have a globalize-this checkbox, but it should.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Globalize preferences that specify class instead of type | mediawiki/extensions/GlobalPreferences | master | +36 -9 |
Related Objects
Related Objects
- Mentioned In
- T172585: Need support for Echo notification preferences
- Mentioned Here
- T68869: Update Global preferences UI
Event Timeline
Comment Actions
This is caused by preferences that set 'class' instead of 'type'. On enwiki, there are 12 such preferences (some of them are just UI elements):
| Name | Class | Comments |
| timecorrection (which this bug requests) | HTMLSelectOrOtherField | should be global |
| cirrussearch-pref-completion-profile | CirrusSearch\HTMLCompletionProfileSettings | should be global |
| betafeatures-section-desc | HTMLTextBlockField | ignore |
| betafeatures-auto-enroll | NewHTMLCheckField | should be global |
| betafeatures-breaking-hr | HTMLHorizontalRuleField | ignore |
| several beta feature checkboxes | HTMLFeatureField | should be global |
| echo-subscriptions | HTMLCheckMatrix | should be global |
echo-subscriptions is extremely problematic because it's a composite form element representing multiple preferences that are stored separately.
I think I'm going to create a whitelist of classes for now. Not sure what to do about Echo preferences though, will open a separate bug for it.
Comment Actions
Change 370304 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/GlobalPreferences@master] Globalize preferences that specify class instead of type
Comment Actions
The above patch fixes the issue wherever possible, however highlight on hover doesn't work for BetaFeatures checkboxes because of oojas trickery.
Comment Actions
Change 370304 merged by jenkins-bot:
[mediawiki/extensions/GlobalPreferences@master] Globalize preferences that specify class instead of type