Page MenuHomePhabricator

Allow timezone to be global
Closed, ResolvedPublic2 Estimated Story Points


The timecorrection preference on Special:GlobalPreferences currently doesn't have a globalize-this checkbox, but it should.

Event Timeline

kaldari triaged this task as Medium priority.Aug 2 2017, 12:02 AM
kaldari edited projects, added Community-Tech-Sprint; removed Community-Tech.
kaldari set the point value for this task to 2.

This is caused by preferences that set 'class' instead of 'type'. On enwiki, there are 12 such preferences (some of them are just UI elements):

timecorrection (which this bug requests)HTMLSelectOrOtherFieldshould be global
cirrussearch-pref-completion-profileCirrusSearch\HTMLCompletionProfileSettingsshould be global
betafeatures-auto-enrollNewHTMLCheckFieldshould be global
several beta feature checkboxesHTMLFeatureFieldshould be global
echo-subscriptionsHTMLCheckMatrixshould be global

echo-subscriptions is extremely problematic because it's a composite form element representing multiple preferences that are stored separately.

I think I'm going to create a whitelist of classes for now. Not sure what to do about Echo preferences though, will open a separate bug for it.

Change 370304 had a related patch set uploaded (by MaxSem; owner: MaxSem):
[mediawiki/extensions/GlobalPreferences@master] Globalize preferences that specify class instead of type

The above patch fixes the issue wherever possible, however highlight on hover doesn't work for BetaFeatures checkboxes because of oojas trickery.

Patch looks good to me. The OOJS stuff can be tackled in the UI work of T68869.

Change 370304 merged by jenkins-bot:
[mediawiki/extensions/GlobalPreferences@master] Globalize preferences that specify class instead of type