Add validation to input json in API
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Lokal_Profil
	Aug 4 2017, 2:05 PM

Description

Per https://gerrit.wikimedia.org/r/#/c/358378/11/includes/WikispeechApi.php@29

Also consider changing to FormatJson.

Note that with FormatJson::parse( $parameters['removetags'] ) we don't get the same result as with json_decode( $parameters['removetags'], true ).

Details

	Subject	Repo	Branch	Lines +/-
	Validate value of API parameter "removetags"	mediawiki/extensions/Wikispeech	master	+171 -7

Customize query in gerrit

Related Objects

Mentioned In: T161097: Recitation should include the article title
T177256: Decide whether we want to move phpcs.xml to .phpcs.xml
T175810: Add lexicon tool special page in Wikispeech extension
rEWIS6993ef482050: Validate value of API parameter "removetags"
rEWIS959004e5e573: Validate value of API parameter "removetags"
rEWISf09faa3789a4: Validate value of API parameter "removetags"
rEWIS209426e113eb: Validate value of API parameter "removetags"
Mentioned Here: rEWIS01f254d951c7: Add lexicon tool special page in Wikispeech extension
rEWIScdda3ee55ad8: build: Updating mediawiki/mediawiki-codesniffer to 13.0.0
rEWISe559d7521f36: Add specialpage alias for WikispeechLexiconTool
rEWIS551ec230bbb9: build: Updating mediawiki/mediawiki-codesniffer to 14.1.0
rEWIS6993ef482050: Validate value of API parameter "removetags"
rEWIS8824cf833b1b: build: Add MinusX
rEWIS3dd8daf29db5: Recite article title
rEWIS1929c0694e2e: build: Always exclude node_modules
T161097: Recitation should include the article title
T175810: Add lexicon tool special page in Wikispeech extension
T177256: Decide whether we want to move phpcs.xml to .phpcs.xml

Event Timeline

Lokal_Profil created this task.Aug 4 2017, 2:05 PM

Lokal_Profil moved this task from Backlog to Technical debt on the Wikispeech-WMSE board.Aug 4 2017, 2:21 PM

Sebastian_Berlin-WMSE added a project: User-Sebastian_Berlin-WMSE.Sep 6 2017, 1:17 PM

Sebastian_Berlin-WMSE moved this task from Backlog to This Week on the User-Sebastian_Berlin-WMSE board.

Note that with FormatJson::parse( $parameters['removetags'] ) we don't get the same result as with json_decode( $parameters['removetags'], true ).

Even when options contain FormatJson::FORCE_ASSOC?

In T172523#3584400, @Sebastian_Berlin-WMSE wrote:

Note that with FormatJson::parse( $parameters['removetags'] ) we don't get the same result as with json_decode( $parameters['removetags'], true ).

Even when options contain FormatJson::FORCE_ASSOC?

Can't remember what I tried :/

Change 376493 had a related patch set uploaded (by Sebastian Berlin (WMSE); owner: Sebastian Berlin (WMSE)):
[mediawiki/extensions/Wikispeech@master] Validate value of API parameter "removetags"

https://gerrit.wikimedia.org/r/376493

gerritbot added a project: Patch-For-Review.Sep 7 2017, 10:16 AM

Sebastian_Berlin-WMSE mentioned this in rEWIS209426e113eb: Validate value of API parameter "removetags".Sep 7 2017, 10:39 AM

Sebastian_Berlin-WMSE mentioned this in rEWISf09faa3789a4: Validate value of API parameter "removetags".Sep 7 2017, 11:37 AM

Sebastian_Berlin-WMSE mentioned this in rEWIS959004e5e573: Validate value of API parameter "removetags".Sep 7 2017, 11:54 AM

Sebastian_Berlin-WMSE moved this task from This Week to Waitin' on the User-Sebastian_Berlin-WMSE board.Sep 7 2017, 12:07 PM

Sebastian_Berlin-WMSE moved this task from Waitin' to This Week on the User-Sebastian_Berlin-WMSE board.Oct 16 2017, 6:13 AM

Sebastian_Berlin-WMSE mentioned this in rEWIS6993ef482050: Validate value of API parameter "removetags".Oct 26 2017, 7:29 AM

Change 376493 merged by jenkins-bot:
[mediawiki/extensions/Wikispeech@master] Validate value of API parameter "removetags"

https://gerrit.wikimedia.org/r/376493

Sebastian_Berlin-WMSE moved this task from This Week to Done on the User-Sebastian_Berlin-WMSE board.Oct 27 2017, 6:22 AM