Page MenuHomePhabricator
Create Task
Maniphest T172850

Replace and deprecate abandoned LESS variable greys from Wikimedia products
Closed, ResolvedPublic
Actions

Description

Outdated grey LESS variables, before current WikimediaUI color palette has been established, to replace and deprecate:

Products

  • MediaWiki core: mediawiki.ui
  • MediaWiki core: Widgets
  • MediaWiki core: RCFilters
  • Vector
  • MinervaNeue CSS/LESS
    • MinervaNeue SVG
  • MobileFrontend
    • MobileFrontend SVG

Extensions

  • GettingStarted
  • Related Articles
  • UploadWizard

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Volker_E created this task.Aug 9 2017, 6:05 AM
gerritbot subscribed.Aug 9 2017, 9:49 PM

Change 370953 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/RelatedArticles@master] Replace abandoned colors with current WikimediaUI ones

https://gerrit.wikimedia.org/r/370953

gerritbot added a project: Patch-For-Review.Aug 9 2017, 9:49 PM
Volker_E updated the task description. (Show Details)Aug 9 2017, 9:55 PM
Volker_E updated the task description. (Show Details)Aug 9 2017, 9:58 PM
Volker_E updated the task description. (Show Details)Aug 9 2017, 10:01 PM
gerritbot added a comment.Aug 9 2017, 10:07 PM

Change 370953 merged by jenkins-bot:
[mediawiki/extensions/RelatedArticles@master] Replace abandoned colors with current WikimediaUI ones

https://gerrit.wikimedia.org/r/370953

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)).Aug 9 2017, 11:00 PM
gerritbot added a comment.Aug 10 2017, 5:32 PM

Change 371082 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/skins/Vector@master] Replace @colorGray9 with static color value #999

https://gerrit.wikimedia.org/r/371082

gerritbot added a comment.Aug 10 2017, 5:51 PM

Change 371099 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/skins/MinervaNeue@master] Replace abandoned color with current WikimediaUI one

https://gerrit.wikimedia.org/r/371099

Volker_E updated the task description. (Show Details)Aug 10 2017, 5:52 PM
Volker_E updated the task description. (Show Details)Aug 10 2017, 5:58 PM
gerritbot added a comment.Aug 10 2017, 6:00 PM

Change 371082 merged by jenkins-bot:
[mediawiki/skins/Vector@master] Replace @colorGray9 with static color value #999

https://gerrit.wikimedia.org/r/371082

gerritbot added a comment.Aug 10 2017, 6:18 PM

Change 371099 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Replace abandoned color with current WikimediaUI one

https://gerrit.wikimedia.org/r/371099

gerritbot added a comment.Aug 10 2017, 7:25 PM

Change 371120 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/MobileFrontend@master] Replace abandoned @colorGray13 with current WikimediaUI one

https://gerrit.wikimedia.org/r/371120

gerritbot added a comment.Aug 10 2017, 8:01 PM

Change 371120 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Replace abandoned @colorGray13 with current WikimediaUI one

https://gerrit.wikimedia.org/r/371120

SamanthaNguyen unsubscribed.Aug 12 2017, 1:39 AM
Volker_E moved this task from Unsorted to Color consistency on the UI-Standardization board.Aug 15 2017, 9:43 PM
Volker_E added a comment.Aug 15 2017, 9:56 PM

Remaining @colorGray13 patch is https://gerrit.wikimedia.org/r/#/c/372032/

Volker_E updated the task description. (Show Details)Aug 16 2017, 3:59 PM
Volker_E added a comment.Aug 16 2017, 4:25 PM

So far those were the semantic greys variable names, a search for hex color values makes clear, we're not completely done yet.

Jdlrobson added a comment.Aug 16 2017, 4:47 PM

Above patch is merged. https://gerrit.wikimedia.org/r/#/c/370503/1 needs rebasing and merging before they come back ;-)!

Volker_E added a subtask: T150731: Align CX to overhauled WikimediaUI color palette.Aug 16 2017, 10:58 PM
Volker_E moved this task from Backlog to Review on the UI-Standardization-Kanban board.Aug 16 2017, 11:16 PM
Volker_E updated the task description. (Show Details)Aug 17 2017, 8:28 PM
gerritbot added a comment.Aug 17 2017, 9:20 PM

Change 372455 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/MobileFrontend@master] Replace abandoned @colorGray3 with current WikimediaUI palette one

https://gerrit.wikimedia.org/r/372455

gerritbot added a comment.Aug 17 2017, 9:36 PM

Change 372455 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Replace abandoned @colorGray3 with current WikimediaUI palette one

https://gerrit.wikimedia.org/r/372455

gerritbot added a comment.Aug 17 2017, 9:43 PM

Change 372460 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/GettingStarted@master] Replace abandoned colors with current WikimediaUI ones

https://gerrit.wikimedia.org/r/372460

gerritbot added a comment.Aug 17 2017, 9:47 PM

Change 372460 merged by jenkins-bot:
[mediawiki/extensions/GettingStarted@master] Replace abandoned colors with current WikimediaUI ones

https://gerrit.wikimedia.org/r/372460

Volker_E updated the task description. (Show Details)Aug 17 2017, 9:58 PM
gerritbot added a comment.Aug 17 2017, 10:04 PM

Change 372468 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/skins/MinervaNeue@master] Replace abandoned @colorGray13 with current WikimediaUI one

https://gerrit.wikimedia.org/r/372468

gerritbot added a comment.Aug 17 2017, 10:20 PM

Change 372468 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Replace abandoned @colorGray13 with current WikimediaUI one

https://gerrit.wikimedia.org/r/372468

Volker_E mentioned this in T152025: Align MediaWiki core UI elements with WikimediaUI color palette.Aug 17 2017, 11:41 PM
ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)); removed MW-1.30-release-notes (WMF-deploy-2017-08-15 (1.30.0-wmf.14)).Aug 21 2017, 7:01 PM
Jrbranaa subscribed.Aug 23 2017, 11:19 PM

Not clear to me why this is Technical Debt. If I understand this task correctly, it's abandoning/deprecating colors used in the UI. From what I can tell from the code changes, there was no refactoring done, just a change in color.

I'm trying to build an understanding of what we've been labeling as TD thus far so that we can come to a common understanding. Please see https://www.mediawiki.org/wiki/Technical_debt for our work in progress definition.

Jrbranaa removed a project: Technical-Debt.Aug 23 2017, 11:26 PM
Volker_E added a comment.Aug 24 2017, 6:38 PM

@Jrbranaa Thanks for the pointer. The Technical-Debt tag happened to be added to the parent task by another user as there has been a lot of color values historically grown without any clear design guideline. Now we've got WikimediaUI Base with it's centralized color variables and we're currently under way of replacing the remaining outdated values with central ones before being able to switch over to Less variables. My understanding was that this could be described as technical debt as well.
But I'm fine anyways.

Jdlrobson added a comment.Aug 24 2017, 6:39 PM

This does seems like technical debt to me. There is an unanswered question about how we define UX debt here: https://www.mediawiki.org/wiki/Topic:Twtqgo3vibq7cz8h

Jrbranaa added a comment.Aug 24 2017, 6:43 PM

Thanks @Volker_E, I've noticed other examples where parent tasks are the tasks actually describing the technical debt aspect of the change and the subtasks are just work elements towards that goal. I think the description that you've provided is a good example of technical-debt - Going from a distributed approach to setting those values to a central approach. Reduces potential errors and makes life better for developers :-)

Jrbranaa added a project: Technical-Debt.Aug 24 2017, 6:43 PM
gerritbot added a comment.Aug 24 2017, 7:52 PM

Change 373677 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] RCFilters: Align remaining outdated greys to WikimediaUI palette ones

https://gerrit.wikimedia.org/r/373677

Volker_E updated the task description. (Show Details)Aug 24 2017, 9:21 PM
Volker_E updated the task description. (Show Details)Aug 24 2017, 10:27 PM
gerritbot added a comment.Aug 24 2017, 10:32 PM

Change 373677 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Align remaining outdated greys to WikimediaUI palette ones

https://gerrit.wikimedia.org/r/373677

ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)); removed MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)).Aug 24 2017, 11:00 PM
gerritbot added a comment.Aug 24 2017, 11:21 PM

Change 373711 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] widgets: Replace outdated colors with WikimediaUI palette ones

https://gerrit.wikimedia.org/r/373711

Volker_E updated the task description. (Show Details)Aug 25 2017, 1:07 PM
Volker_E updated the task description. (Show Details)
Volker_E added a subscriber: Jdforrester-WMF.
gerritbot added a comment.Aug 25 2017, 1:07 PM

Change 373884 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/MobileFrontend@master] Align 'noimage' to WikimediaUI color palette

https://gerrit.wikimedia.org/r/373884

gerritbot added a comment.Aug 25 2017, 1:13 PM

Change 373887 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/RelatedArticles@master] Align 'noimage' to WikimediaUI color palette

https://gerrit.wikimedia.org/r/373887

gerritbot added a comment.Aug 25 2017, 2:38 PM

Change 373898 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/extensions/MobileFrontend@master] Align SVGs to color palette and optimize

https://gerrit.wikimedia.org/r/373898

gerritbot added a comment.Aug 25 2017, 7:57 PM

Change 373960 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/skins/MinervaNeue@master] Align SVGs to color palette and optimize

https://gerrit.wikimedia.org/r/373960

gerritbot added a comment.Aug 28 2017, 10:04 AM

Change 373711 merged by jenkins-bot:
[mediawiki/core@master] widgets: Replace outdated colors with WikimediaUI palette ones

https://gerrit.wikimedia.org/r/373711

ReleaseTaggerBot edited projects, added MW-1.30-release-notes; removed MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)).Aug 28 2017, 11:00 AM
gerritbot added a comment.Aug 28 2017, 3:01 PM

Change 373960 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Align SVGs to color palette and optimize

https://gerrit.wikimedia.org/r/373960

ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)); removed MW-1.30-release-notes.Aug 28 2017, 4:00 PM
gerritbot added a comment.Aug 28 2017, 6:25 PM

Change 373884 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Align 'noimage' to WikimediaUI color palette

https://gerrit.wikimedia.org/r/373884

Volker_E updated the task description. (Show Details)Aug 28 2017, 6:54 PM
gerritbot added a comment.Aug 28 2017, 9:49 PM

Change 373898 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Align SVGs to color palette and optimize

https://gerrit.wikimedia.org/r/373898

gerritbot added a comment.Sep 1 2017, 1:22 PM

Change 373887 merged by jenkins-bot:
[mediawiki/extensions/RelatedArticles@master] Align 'noimage' to WikimediaUI color palette

https://gerrit.wikimedia.org/r/373887

ReleaseTaggerBot edited projects, added MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)); removed MW-1.30-release-notes (WMF-deploy-2017-08-29 (1.30.0-wmf.16)).Sep 1 2017, 2:00 PM
Volker_E closed this task as Resolved.Sep 12 2017, 12:22 AM
Volker_E removed a project: Patch-For-Review.
Volker_E updated the task description. (Show Details)
Volker_E removed a subscriber: gerritbot.
Volker_E closed subtask T150731: Align CX to overhauled WikimediaUI color palette as Resolved.Sep 12 2017, 8:26 AM
Liuxinyu970226 unsubscribed.Sep 12 2017, 9:48 AM
Volker_E raised the priority of this task from High to Needs Triage.Sep 20 2017, 3:36 AM
Volker_E moved this task from Review to Done on the UI-Standardization-Kanban board.
Volker_E renamed this task from Replace and deprecate abandoned greys from Wikimedia products to Replace and deprecate abandoned LESS variable greys from Wikimedia products.Sep 23 2017, 3:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits