Page MenuHomePhabricator

NWE shouldn't intercept when viewing deleted revisions
Closed, ResolvedPublic1 Estimated Story Points

Description

Repro: have the beta feature enabled, go to the list of deleted revisions for a page, click on a revision, click "Show preview".

I see: NWE tries to open Special:Undelete for editing and you get an empty editor instead of preview.

Expected: same preview dialog as without NWE.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

And if the article exists, you will then see preview of the last version of the article, not the old version that you wanted to see.

Deskana renamed this task from NWE intercepts previews of deleted pages to NWE shouldn't intercept when viewing deleted revisions.Aug 22 2017, 7:24 PM
Deskana triaged this task as Medium priority.
Deskana moved this task from To Triage to TR1: Releases on the VisualEditor board.

Change 373927 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Disable VE on Special:Undelete

https://gerrit.wikimedia.org/r/373927

Change 373927 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Disable VE on Special:Undelete

https://gerrit.wikimedia.org/r/373927

Deskana assigned this task to Esanders.

Change 471771 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Revert "Disable VE on Special:Undelete"

https://gerrit.wikimedia.org/r/471771

Change 471771 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Revert "Disable VE on Special:Undelete"

https://gerrit.wikimedia.org/r/471771