Page MenuHomePhabricator
Create Task
Maniphest T173282

Unused class ApiNewsletterManage.php in Newsletter extension ?
Closed, ResolvedPublic
Actions

Description

This class --> /var/www/core/core/extensions/Newsletter/includes/api/ApiNewsletterManage.php seems to be dead ?

Eitherway, it accepts a param 'publisher' which I dont think is used anymore.

Details

SubjectRepoBranchLines +/-
Remove unused API class ApiNewsletterManagemediawiki/extensions/Newslettermaster+1 -103
Customize query in gerrit

Event Timeline

01tonythomas created this task.Aug 13 2017, 10:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 13 2017, 10:19 PM
gerritbot subscribed.Aug 13 2017, 10:25 PM

Change 371762 had a related patch set uploaded (by 01tonythomas; owner: 01tonythomas):
[mediawiki/extensions/Newsletter@master] Remove unused API class ApiNewsletterManage

https://gerrit.wikimedia.org/r/371762

gerritbot added a project: Patch-For-Review.Aug 13 2017, 10:25 PM
gerritbot added a comment.Aug 14 2017, 2:40 AM

Change 371762 merged by jenkins-bot:
[mediawiki/extensions/Newsletter@master] Remove unused API class ApiNewsletterManage

https://gerrit.wikimedia.org/r/371762

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-08-22 (1.30.0-wmf.15)).Aug 21 2017, 5:02 PM
Qgil assigned this task to 01tonythomas.Aug 29 2017, 8:05 PM
Qgil subscribed.

The patch has been merged. Is the problem fixed now?

01tonythomas closed this task as Resolved.Aug 30 2017, 6:28 AM
In T173282#3563724, @Qgil wrote:

The patch has been merged. Is the problem fixed now?

Yes it is!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits