Invalid diff mode should be ignored
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Schnark
	Aug 16 2017, 7:04 AM

Description

On https://de.wikipedia.beta.wmflabs.org/w/index.php?title=Benutzer:Raymond&curid=1239&diff=20583&oldid=20582&visualdiff&diffmode=foo (note the invalid parameter for diffmode), no button in the diff mode switcher is selected. While this is only a minor visual glitch and switching works as expected, in such a case the invalid parameter should be ignored (which here means that the Wikitext button should be selected).

Details

	Subject	Repo	Branch	Lines +/-
	DiffPage.init: Enforce a valid diff mode	mediawiki/extensions/VisualEditor	master	+5 -0

Customize query in gerrit

Event Timeline

Schnark created this task.Aug 16 2017, 7:04 AM

Restricted Application added a project: VisualEditor. · View Herald TranscriptAug 16 2017, 7:04 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

• Deskana triaged this task as Low priority.Aug 22 2017, 2:11 PM

• Deskana set the point value for this task to 1.

• Deskana moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.

DLynch claimed this task.Feb 22 2018, 5:43 PM

DLynch raised the priority of this task from Low to Medium.

DLynch moved this task from TR6: Visual diffs to Current work on the VisualEditor board.

DLynch edited projects, added VisualEditor (Current work); removed VisualEditor.

Change 413420 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] DiffPage.init: Enforce a valid diff mode

https://gerrit.wikimedia.org/r/413420

gerritbot added a project: Patch-For-Review.Feb 22 2018, 5:48 PM

DLynch moved this task from Incoming to Code review on the VisualEditor (Current work) board.Feb 22 2018, 5:49 PM

Jdforrester-WMF moved this task from Code review to Product owner review on the VisualEditor (Current work) board.Feb 22 2018, 5:55 PM

Change 413420 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] DiffPage.init: Enforce a valid diff mode

https://gerrit.wikimedia.org/r/413420

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)).Feb 22 2018, 7:00 PM

• Deskana closed this task as Resolved.Feb 23 2018, 10:45 AM

Ryasmeen added a project: Verified.Feb 26 2018, 11:47 PM