Page MenuHomePhabricator

Invalid diff mode should be ignored
Closed, ResolvedPublic1 Estimated Story Points


On (note the invalid parameter for diffmode), no button in the diff mode switcher is selected. While this is only a minor visual glitch and switching works as expected, in such a case the invalid parameter should be ignored (which here means that the Wikitext button should be selected).

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Deskana set the point value for this task to 1.
Deskana moved this task from To Triage to TR6: Visual diffs on the VisualEditor board.
DLynch raised the priority of this task from Low to Medium.
DLynch moved this task from TR6: Visual diffs to Current work on the VisualEditor board.
DLynch edited projects, added VisualEditor (Current work); removed VisualEditor.

Change 413420 had a related patch set uploaded (by DLynch; owner: DLynch):
[mediawiki/extensions/VisualEditor@master] DiffPage.init: Enforce a valid diff mode

Change 413420 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] DiffPage.init: Enforce a valid diff mode