Page MenuHomePhabricator

Add more standard variables to delete action
Open, Stalled, LowPublicFeature

Description

old_wikitext, old_size etc. could be helpful. Not sure if this could be a breaking change.

Event Timeline

I started poking this. But I realize it could worsen situation about info leaks...

Change 707299 had a related patch set uploaded (by Matěj Suchánek; author: Matěj Suchánek):

[mediawiki/extensions/AbuseFilter@master] [POC] Old wikitext for 'delete' action

https://gerrit.wikimedia.org/r/707299

I started poking this. But I realize it could worsen situation about info leaks...

Yeah, I think when it comes to page deletion, AF was built with the idea in mind that any info leak wouldn't actually be an info leak because it'd only be visible to privileged users. I think this is something that needs to change, but it's hard to tell how.

The patch is ready. As foreseen, this feature will unfortunately result in T44734 whenever a delete action triggers a filter.

matej_suchanek changed the subtype of this task from "Task" to "Feature Request".
matej_suchanek changed the task status from Open to Stalled.Oct 23 2023, 2:26 PM
matej_suchanek removed matej_suchanek as the assignee of this task.

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AbuseFilter/+/707299/comments/4768563c_d8930301

I'd rather see T44734 resolved first (with the caveat that I'm not entirely sure about the correctness of my patch), after which I see no objections to moving this forward