Reading web extensions are incompatible with QUnit 2
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Jdlrobson
	Aug 30 2017, 6:20 PM

Description

I'm seeing issues when I install any extension or skin with unit tests
e.g. ~~RelatedArticles~~(fixed), MobileFrontend, ~~Minerva~~(fixed)
Core tests seem to be working completely fine.

TypeError: test.callback.call is not a function
    at runTest (http://localhost:8888/w/load.php?debug=false&lang=en&modules=jquery.qunit&only=scripts&raw=1&skin=vector&sync=1:20:162)
    at Test.run (http://localhost:8888/w/load.php?debug=false&lang=en&modules=jquery.qunit&only=scripts&raw=1&skin=vector&sync=1:19:914)
    at http://localhost:8888/w/load.php?debug=false&lang=en&modules=jquery.qunit&only=scripts&raw=1&skin=vector&sync=1:23:875
    at Object.advance (http://localhost:8888/w/load.php?debug=false&lang=en&modules=jquery.qunit&only=scripts&raw=1&skin=vector&sync=1:14:956)
    at begin (http://localhost:8888/w/load.php?debug=false&lang=en&modules=jquery.qunit&only=scripts&raw=1&skin=vector&sync=1:44:336)
    at http://localhost:8888/w/load.php?debug=false&lang=en&modules=jquery.qunit&only=scripts&raw=1&skin=vector&sync=1:43:855

The reason is there is an upgrade to QUnit 2 going on.
Right now QUnit 1 is used for Jenkins, but that's going to go away soon.
See https://phabricator.wikimedia.org/T174598#3568353 for an explanation.
We should update our tests or we will suffer tremendous pain with merging very soon!

Sign off steps (developer only)

Locally update MobileFrontend extension
$wgEnableJavaScriptTest = true; in LocalSettings
Verify that all the tests for MobileFrontend pass when you visit http://localhost:8888/w/index.php/Special:JavaScriptTest/qunit/plain

Details

Subject	Repo	Branch	Lines +/-
QUnit: Drop assertions for expected number of tests	mediawiki/extensions/MobileFrontend	master	+305 -267
Make RelatedArticles tests QUnit 2 compatible	mediawiki/extensions/RelatedArticles	master	+3 -3
Make Minerva QUnit tests v2 compatible	mediawiki/skins/MinervaNeue	master	+3 -3

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Krinkle	T171221 Drop setup/teardown backwards compatibility calls for beforeEach/afterEach in QUnit.newMwEnvironment
Resolved	Krinkle	T170515 Upgrade MediaWiki core to QUnit 2
Resolved	Jdlrobson	T162936 Improve developer happiness in reading web maintained extensions
Resolved	None	T174598 Reading web extensions are incompatible with QUnit 2

Event Timeline

Jdlrobson created this task.Aug 30 2017, 6:20 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 30 2017, 6:20 PM

(I'm using grunt karma in mean time but other people might be depending on that page to run tests)

I'm guessing this is because of usages of QUnit.expect and async....

Jdlrobson edited subscribers, added: Krinkle; removed: Aklapper.Aug 30 2017, 9:40 PM

In T174598#3568112, @Jdlrobson wrote:

I'm guessing this is because of usages of QUnit.expect and async....

Indeed. These presumably come from one of the installed extensions (RelatedArticles, MobileFrontend).

Those deprecated methods were removed in QUnit 2.

The Special-page runner was upgraded to QUnit 2 last month. There are still some issues left unaddressed in Wikibase that forced us to leave the grunt-cli runner on QUnit 1.x at the moment (used by Jenkins). The Special-page runner can be used to debug any incompatibilities with QUnit 2 in preparation for the grunt-cli upgrade.

See:

Krinkle moved this task from Inbox to QUnit on the MediaWiki-Core-Tests board.Aug 30 2017, 10:21 PM

Sounds like these need fixing for MobileFrontend etc though?

I assume we don't want to support them... but we'd still like to run them .

Change 374908 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] QUnit: Drop assertions for expected number of tests

https://gerrit.wikimedia.org/r/374908

gerritbot added a project: Patch-For-Review.Aug 30 2017, 11:05 PM

Jdlrobson renamed this task from Special:JavaScript/qunit/test unusable to Reading web extensions are incompatible with QUnit 2.Aug 31 2017, 1:44 PM

Jdlrobson added a project: Web-Team-Backlog.

Change 374992 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Make Minerva QUnit tests v2 compatible

https://gerrit.wikimedia.org/r/374992

Jdlrobson updated the task description. (Show Details)Aug 31 2017, 1:46 PM

Jdlrobson moved this task from Incoming to Upcoming on the Web-Team-Backlog board.

Change 374992 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Make Minerva QUnit tests v2 compatible

https://gerrit.wikimedia.org/r/374992

Jdlrobson removed projects: Patch-For-Review, MinervaNeue.Aug 31 2017, 6:20 PM

Jdlrobson updated the task description. (Show Details)

ReleaseTaggerBot added a project: MW-1.30-release-notes (WMF-deploy-2017-09-05 (1.30.0-wmf.17)).Aug 31 2017, 7:01 PM

Jdlrobson added a parent task: T162936: Improve developer happiness in reading web maintained extensions.Sep 1 2017, 3:17 PM

Change 375390 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/RelatedArticles@master] Make RelatedArticles tests QUnit 2 compatible

https://gerrit.wikimedia.org/r/375390

gerritbot added a project: Patch-For-Review.Sep 1 2017, 3:17 PM

Can someone please sanity check https://gerrit.wikimedia.org/r/#/c/374908/ since I'm touching lots of files. Then we can call this task done.

Jdlrobson claimed this task.Sep 1 2017, 3:25 PM

Jdlrobson removed a project: RelatedArticles.

Jdlrobson updated the task description. (Show Details)

Jdlrobson moved this task from To Do to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.

Change 375390 merged by jenkins-bot:
[mediawiki/extensions/RelatedArticles@master] Make RelatedArticles tests QUnit 2 compatible

https://gerrit.wikimedia.org/r/375390

ovasileva moved this task from Upcoming to 2017-18 Q1 on the Web-Team-Backlog board.Sep 5 2017, 12:04 PM

@Jdlrobson, I left a comment in gerrit, in case you missed it.

https://gerrit.wikimedia.org/r/374908 has a +1.
I am going on vacation later today.

Change 374908 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] QUnit: Drop assertions for expected number of tests

https://gerrit.wikimedia.org/r/374908

@pmiazga has merged it. +2.

Jdlrobson updated the task description. (Show Details)Sep 8 2017, 6:46 PM

Jdlrobson removed a project: Patch-For-Review.

@bmansurov on irc said he can have a go at signing this off

Tests are passing locally.

Krinkle added a parent task: T170515: Upgrade MediaWiki core to QUnit 2.Sep 18 2017, 6:04 PM

Reading web extensions are incompatible with QUnit 2Closed, ResolvedPublicActions