Page MenuHomePhabricator

Use CSS to set the width of cells at Special:Newsletters
Closed, ResolvedPublic

Description

Currently it uses the attribute "width", which is deprecated:
https://validator.w3.org/nu/?doc=https%3A%2F%2Fwww.mediawiki.org%2Fwiki%2FSpecial%3ANewsletters

Error: The width attribute on the td element is obsolete. Use CSS instead.
From line 50, column 5; to line 51, column 47
body>↩<tr>↩<td class="TablePager_col_nl_name" width="20%"><a hre

Event Timeline

He7d3r created this task.Sep 11 2017, 10:50 PM
Restricted Application added subscribers: TerraCodes, Aklapper. · View Herald TranscriptSep 11 2017, 10:50 PM
QuimGil added subscribers: D3r1ck01, QuimGil.

Thank you @He7d3r for reporting, thank you @D3r1ck01 for promoting, and thank you @Eugene233 for taking this task. Good luck! If you have questions, please ask.

Also @Eugene233, now that this task is assigned to you, you can set the priority.

@QuimGil - Thanks for the acknowledgement.

^ While installing Newsletter extension and trying to navigate the special page I get the following. I am not sure why I have this issue any help could be appreciated.

Error seems to be out of the way after running the update script.

Eugene233 added a subscriber: Qgil.Sep 19 2017, 9:54 AM

@He7d3r @Qgil Do we have to write or remove any tests as regarding the code that has been changed?

QuimGil removed a subscriber: Qgil.Sep 19 2017, 10:12 AM

@Eugene233 you asked me via chat, but then I have thought a bit more, and... Considering that this is your first task for the Newsletter project, I think it is better that you upload a patch with the fix sooner than later. Since it is a quite visible change, I think writing tests here is not so important as to delay that first upload and the beginning of the code review.

Change 378867 had a related patch set uploaded (by Eugene233; owner: Eugene233):
[mediawiki/extensions/Newsletter@master] Use CSS to set the width of cells at Special:Newsletters

https://gerrit.wikimedia.org/r/378867

Change 378867 merged by jenkins-bot:
[mediawiki/extensions/Newsletter@master] Use CSS to set the width of cells at Special:Newsletters

https://gerrit.wikimedia.org/r/378867

So I guess this can be closed? Or is there something else left to work on?