Page MenuHomePhabricator

[BUG] Invisible texts in Popup Dialog in Dark Mode
Closed, ResolvedPublicBUG REPORT

Description

Steps to Reproduce:

  1. Read an article in Dark Mode
  2. Long press on the inner links and will see a pop-up dialog

Actual Results

Invisible texts in dialog

Expected Results

Visible texts in dialog

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

It looks like there's an Android style definition that we're failing to override when changing to Dark mode.

Change 383754 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@master] Fix: Invisible texts in Popup Dialog in Dark Mode

https://gerrit.wikimedia.org/r/383754

Change 383754 merged by jenkins-bot:
[apps/android/wikipedia@master] Fix: Invisible texts in Popup Dialog in Dark Mode

https://gerrit.wikimedia.org/r/383754

RHo added a subscriber: RHo.

LGTM - On Nexus 5 (6.0.1) - Wikipedia v2.6.206-alpha-2017-11-20

Testing Wikipedia app 2.6.206-alpha-2017-11-2 on ZTE Maven (Z812, Android 5). This is fixed as seen in the below screencap the dialog has visible texts in dark mode.

ABorbaWMF added a subscriber: ABorbaWMF.

Tested on 2.6.206-alpha-2017-11-29 on a Pixel and a Nexus 4. Looks good to me.

cooltey reopened this task as Open.EditedJun 26 2018, 8:58 PM

From OTRS: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=10746953
I can reproduce it on Android 5.0.1 ( API23) device


Change 449381 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@master] Fix: invisibile texts in alertDialog in dark mode (API21)

https://gerrit.wikimedia.org/r/449381

Change 449381 merged by jenkins-bot:
[apps/android/wikipedia@master] Fix: invisibile texts in alertDialog in dark mode (API21)

https://gerrit.wikimedia.org/r/449381