[BUG] Invisible texts in Popup Dialog in Dark Mode
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	cooltey
	Sep 29 2017, 11:43 PM

Description

Steps to Reproduce:

Read an article in Dark Mode
Long press on the inner links and will see a pop-up dialog

Actual Results

Invisible texts in dialog

Fullscreen_9_29_17__4_42_PM.png (1×707 px, 366 KB)

Expected Results

Visible texts in dialog

Details

	Subject	Repo	Branch	Lines +/-
	Fix: invisibile texts in alertDialog in dark mode (API21)	apps/android/wikipedia	master	+2 -0
	Fix: Invisible texts in Popup Dialog in Dark Mode	apps/android/wikipedia	master	+16 -2

Customize query in gerrit

Event Timeline

cooltey created this task.Sep 29 2017, 11:43 PM

Restricted Application added a project: Wikipedia-Android-App-Backlog. · View Herald TranscriptSep 29 2017, 11:43 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

cooltey updated the task description. (Show Details)Sep 29 2017, 11:44 PM

It looks like there's an Android style definition that we're failing to override when changing to Dark mode.

Dbrant moved this task from Needs Triage to Android-app-release-v2.7.22x-Fortune-Cookie on the Wikipedia-Android-App-Backlog board.Oct 2 2017, 4:52 PM

Dbrant edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.7.22x-Fortune-Cookie); removed Wikipedia-Android-App-Backlog.

Dbrant moved this task from To Do to Ready for dev on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.22x-Fortune-Cookie) board.Oct 6 2017, 6:43 PM

cooltey claimed this task.Oct 11 2017, 10:10 PM

Change 383754 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@master] Fix: Invisible texts in Popup Dialog in Dark Mode

https://gerrit.wikimedia.org/r/383754

gerritbot added a project: Patch-For-Review.Oct 12 2017, 12:55 AM

cooltey moved this task from Ready for dev to Code Review on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.22x-Fortune-Cookie) board.Oct 12 2017, 12:56 AM

Change 383754 merged by jenkins-bot:
[apps/android/wikipedia@master] Fix: Invisible texts in Popup Dialog in Dark Mode

https://gerrit.wikimedia.org/r/383754

cooltey moved this task from Code Review to Design Signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.22x-Fortune-Cookie) board.Oct 13 2017, 8:39 PM

LGTM - On Nexus 5 (6.0.1) - Wikipedia v2.6.206-alpha-2017-11-20

Testing Wikipedia app 2.6.206-alpha-2017-11-2 on ZTE Maven (Z812, Android 5). This is fixed as seen in the below screencap the dialog has visible texts in dark mode.

Tested on 2.6.206-alpha-2017-11-29 on a Pixel and a Nexus 4. Looks good to me.

Dbrant closed this task as Resolved.Dec 5 2017, 7:34 PM

From OTRS: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=10746953
I can reproduce it on Android 5.0.1 ( API23) device

Screenshot_2018-06-25-23-25-10.png (1×1 px, 199 KB)

Screenshot_2018-06-25-23-27-29.png (1×1 px, 255 KB)

cooltey removed projects: Patch-For-Review, Wikipedia-Android-App-Backlog (Android-app-release-v2.7.22x-Fortune-Cookie).Jun 26 2018, 8:59 PM

cooltey added a project: Wikipedia-Android-App-Backlog.

• Charlotte edited projects, added Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake); removed Wikipedia-Android-App-Backlog.Jun 26 2018, 9:06 PM

Dbrant triaged this task as Low priority.Jul 30 2018, 4:24 PM

Dbrant moved this task from Backlog to Ready for dev on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.

cooltey moved this task from Ready for dev to Doing on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.Jul 30 2018, 10:17 PM

Change 449381 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@master] Fix: invisibile texts in alertDialog in dark mode (API21)

https://gerrit.wikimedia.org/r/449381

gerritbot added a project: Patch-For-Review.Jul 31 2018, 12:24 AM

cooltey moved this task from Doing to Code Review on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.Jul 31 2018, 12:34 AM

Change 449381 merged by jenkins-bot:
[apps/android/wikipedia@master] Fix: invisibile texts in alertDialog in dark mode (API21)

https://gerrit.wikimedia.org/r/449381

Dbrant moved this task from Code Review to QA signoff on the Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake) board.Aug 1 2018, 4:00 PM

Looks good on 2.7.239-alpha-2018-08-06
Tested on android 5.1 and 7.0

• Charlotte edited projects, added Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme); removed Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake).Aug 13 2018, 5:20 PM

cooltey moved this task from Backlog to Ready for signoff on the Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme) board.Aug 14 2018, 6:21 PM

Dbrant closed this task as Resolved.Nov 1 2018, 5:21 PM

	F22692817: Screenshot_2018-06-25-23-25-10.png
	Jun 26 2018, 8:58 PM

	F22692823: Screenshot_2018-06-25-23-27-29.png
	Jun 26 2018, 8:58 PM

	F9903951: Fullscreen_9_29_17__4_42_PM.png
	Sep 29 2017, 11:44 PM

	F11001877: T177129.png
	Nov 26 2017, 2:05 AM

	F10959385: image.png
	Nov 23 2017, 4:41 PM

[BUG] Invisible texts in Popup Dialog in Dark ModeClosed, ResolvedPublicBUG REPORTActions