Page MenuHomePhabricator

Please remove Custom License Marker from Commons Upload Wizard
Open, LowestPublic

Description

Event Timeline

Jeff_G created this task.Oct 1 2017, 5:42 AM
Restricted Application added a project: Multimedia. · View Herald TranscriptOct 1 2017, 5:42 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jeff_G awarded a token.Oct 1 2017, 3:52 PM
Raymond added a subscriber: Raymond.Oct 2 2017, 7:47 PM

Change 382145 had a related patch set uploaded (by Noella94; owner: Noella94):
[mediawiki/extensions/UploadWizard@master] Please remove Custom License Marker from Commons Upload Wizard

https://gerrit.wikimedia.org/r/382145

MarkTraceur moved this task from Untriaged to Triaged on the Multimedia board.Oct 4 2017, 2:20 PM
MarkTraceur assigned this task to Ramsey-WMF.

"Consensus" is a strong word for a discussion between three people, of whom two "voted" for the change. This would not just remove the template transclusion on new files, but stop any user from using a custom license on any upload, greatly reducing the usefulness of the tool (as evidenced by the 500k+ files that use this template) - I'm not convinced this is the way to go, but I'm not the only voice in this discussion anyway.

Would it be acceptable to simply remove the 'templates' entry for the template in question, rather than turning off custom licenses entirely? I'm still not certain there is consensus even to support that move, but I'm asking if that's what you *meant* to do.

@Ramsey-WMF, I'd like your thoughts on this when you get a chance. (assigned)

@CKoerner_WMF you might want to chime in as well.

My understanding of the discussion on Commons is that the automatic adding of the template should be removed. Not the "license" itself. Personally I use it often for {{PD-ineligible}}.

Pinging @Speravir as they might be able to help provide some clarity. I'm personally a little confused on what was discussed on the Village Pump and the commit here. The patch seems to have a larger impact than what was discussed?

With upcoming changes involved with Structured Data on Commons, retaining this template is actually potentially useful for purposes of helping to identify custom template files that will need to be changed to fit into the new (still undecided) structured licenses format.

In short, in the future we'll need to migrate everything to a different system and every little bit that helps us identify what goes where is welcome (including templates like this).

We would like to have *some* sort of standard way to programatically look for these kinds of files that use custom licenses. If it's not Custom_license_marker, we're open to suggestions for items that work equally well or better. Otherwise, we should keep/revert the old functionality.

Steinsplitter added a comment.EditedOct 5 2017, 12:29 PM

With upcoming changes involved with Structured Data on Commons, retaining this template is actually potentially useful for purposes of helping to identify custom template files that will need to be changed to fit into the new (still undecided) structured licenses format.

All template usage has been removed yet & the template has been deleted:

(change visibility) 12:04, 4 October 2017 Steinsplitter (talk | contribs | block) deleted page Template:Custom license marker (unused & deprecated) (view/restore)

Please pull such data from the databases using a mysql query.

Would it be acceptable to simply remove the 'templates' entry for the template in question, rather than turning off custom licenses entirely? I'm still not certain there is consensus even to support that move, but I'm asking if that's what you *meant* to do.

Locally handled yet :-): https://commons.wikimedia.org/w/index.php?title=Template:Custom_license_marker_added_by_UW&diff=260617682&oldid=156005753

Disclaimer: We won't turn off custom licenses (there are hundreds of custom licenses on commons) but just the redundant and incomplete tracking template. Up to date/non incomplete data can be pulled from the database if needed. This is just some really old tracking stuff.

Edit: I think we can close this task then as locally handled, as no configuration change in the code itself is necessary.

MarkTraceur triaged this task as Lowest priority.Oct 5 2017, 2:47 PM

OK, if the template is indeed removed, we can remove it from the config, but the current patch is not really doing that, so we'll wait until the patch matches the request. Thanks for the clarification @Steinsplitter

D3r1ck01 added a subscriber: D3r1ck01.

Removed the Africa-Wikimedia-Developers tag as @Ramsey-WMF is working on this!

Change 382145 abandoned by Noella94:
Please remove Custom License Marker from Commons Upload Wizard

https://gerrit.wikimedia.org/r/382145

Ramsey-WMF reassigned this task from Ramsey-WMF to Cparle.Dec 12 2017, 10:24 PM
Ramsey-WMF added a subscriber: Cparle.

@Cparle could you finish up the patch needed to clean this up? Ticket history should provide the needed info, or ping me with any additional questions.