Description
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T177929 Integrate new layout | |||
| Resolved | None | T177934 content pages - Integrate new layout | |||
| Resolved | None | T180124 Print CSS - Integrate new layout |
Event Timeline
Open issues
business (@tmletzko, @kai.nissen)
delivery uses a dynamic title ("Wikimedia Deutchland - Impressum"), different from the static current one ("Spenden für Freies Wissen - Wikimedia Fördergesellschaft") for the pages. Which one wins?- Spendenquittung in delivery contains a link "Den vereinfachten Zuwendungsbescheid für die Wikimedia Fördergesellschaft können Sie hier herunterladen." at the bottom of the page (w/ dedicated styling), in the content repo it is part of the text. T179930
- Transparenz page has links at the end of the content that are not styled well (not part of delivery). How are they supposed to look? T179931
- Spendenquittung, Transparenz pages have ITZ logo in our content repo that is not present in the delivery, is not styled. Is it to be gone? If not, how is it to be styled? T179929
- delivered favicon.ico & apple-touch-icon.png are still the colored logo. Intentional? T179932
- improvised a Not found page (e.g. /page/jochen) - is that ok? T180106
- improvised an Access denied page (e.g. /show-donation-confirmation) - is that ok? T180107
- improvised an Error page (e.g. /donation/cancel - fails because of HTTP GET instead of POST) - is that ok? T180108
- improvised a System Message page (when submitting donations, membership requests in quick succession - not deep-linkable) - is that ok? T180109
tech (@kai.nissen + devs)
- page_identifier / page_id (used in body id & class) do not match in content repo and delivery which may cause lack of some styles
- delivery has classes identifying page content as <body> id, class on first <div>, class on <main> as well as an additional "theme" class on <body> - should consolidate. Did not implement <main> class which may cause lack of some styles
- build:css & build:js left in Base_Layout.html.twig as todo indicators
- donationForm.js & membershipForm.js not loaded yet - should be done conditionally depending on the respective process
- Datenschutz page uses UL/LI in our content repo that are not present in the delivery, are not styled T179936
- (user changeable) Unterstützerliste mark-up from content repo does not match delivered styles T179938
- content in our content repo uses <strong> (e.g. here) where the delivery - more semantically - uses <hX>, hence styling is different
- css (main.scss) imports fonts from fonts.googleapis.com; something we probably don't want. Download once licensing is checked T179939
- The current is page is supposed to be highlighted in the header navigation by blue font, underline. Currently "Spendenkommentare" is always highlighted. T179940
- notice for clients without javascript, formerly part of layout (no-js-notice from config / no_js_notice_template) not used/present anymore T180110
- its worth noting that non of the page titles in the content repo match the titles shown as navigation link anchors in the delivery, so they can not be reused like {$ 'use_of_resources'|trans( {}, 'pageTitles' ) $}
- copied HTML meta information from 10h16
- delivery uses a dynamic title ("Wikimedia Deutchland - Impressum"), different from the static current one ("Spenden für Freies Wissen - Wikimedia Fördergesellschaft") for the pages. Which one wins?
Wikimedia Fördergesellschaft wins and will always win.
- Spendenquittung in delivery contains a link "Den vereinfachten Zuwendungsbescheid für die Wikimedia Fördergesellschaft können Sie hier herunterladen." at the bottom of the page (w/ dedicated styling), in the content repo it is part of the text.
Yes, we changed that. The change is therefore correct.
- Transparenz page has links at the end of the content that are not styled well (not part of delivery). How are they supposed to look?
I am not sure I know which page you refer to. The only transparenz page I know of is https://wikimedia.de/wiki/Transparenz.
- Spendenquittung, Transparenz pages have ITZ logo in our content repo that is not present in the delivery, is not styled. Is it to be gone? If not, how is it to be styled?
I am not sure what you mean. Isn´t the ITZ logo freely available? Or do you mean where the logo should be placed? If latter, if possible put it at the right top corner. If it is problematic, skip it.
I can not answer the remaining questions or I need another description of the problem.
@tmletzko Thanks for picking this up.
Wikimedia Fördergesellschaft wins and will always win.
Does that mean that all page titles will be static (like currently) "Spenden für Freies Wissen - Wikimedia Fördergesellschaft" or should they be (partially) dynamic like shown in the delivery (part behind the dash)?
The only transparenz page I know of is https://wikimedia.de/wiki/Transparenz.
Yes, references this page, which has two links at the bottom. Are they also supposed to move to right side like in many other places? This page is not demoed in the delivery.
ITZ [...] Or do you mean where the logo should be placed? If latter, if possible put it at the right top corner. If it is problematic, skip it.
Yes, that's what I mean. So far we have not altered the delivered CSS and we are reluctant to do so until "final delivery". Main question is, if we should fix things like that already, or if we'll have a feedback loop with the 3rd party.
Does that mean that all page titles will be static (like currently) "Spenden für Freies Wissen - Wikimedia Fördergesellschaft" or should they be (partially) dynamic like shown in the delivery (part behind the dash)?
basically, there is no deviation between the new skin/application and the "current skin/application", which means however it is solved for our current application, this should be applied to the new one aswell. Does that answer it?
Yes, references this page, which has two links at the bottom. Are they also supposed to move to right side like in many other places? This page is not demoed in the delivery.
within the "Wohin geht meine Spende" there are three exit links. ITZ Logo and the both links refering to the annual plans. The first stays the same, the annual plans links will change when the new mittelverwendung 2018 is finalized. Does this answer your question?
Yes, that's what I mean. So far we have not altered the delivered CSS and we are reluctant to do so until "final delivery". Main question is, if we should fix things like that already, or if we'll have a feedback loop with the 3rd party.
skip it. They forgot the logo and it is not that important in the "Steuerlich absetzbar"
Follow-up to test drive
https://github.com/wmde/fundraising-infrastructure/pull/185
and potentially https://github.com/wmde/FundraisingFrontend/pull/988
@tmletzko @kai.nissen First previews
https://test-spenden-2.wikimedia.de/page/Impressum?skin=cat17 et al.
This will switch your skin preference to cat17. Use https://test-spenden-2.wikimedia.de/?skin=10h16 to switch back to the prod skin.
- improvised a Not found page (e.g. /page/jochen) - is that ok?
- improvised an Access denied page (e.g. /show-donation-confirmation) - is that ok?
- improvised an Error page (e.g. /donation/cancel - fails because of HTTP GET instead of POST) - is that ok?
- improvised a System Message page (when submitting donations, membership requests in quick succession - not deep-linkable) - is that ok?
There should be a headline. Those rather short messages might be missed.
- donationForm.js & membershipForm.js not loaded yet - should be done conditionally depending on the respective process
This is also done like you described in the other skin.
- content in our content repo uses <strong> (e.g. here) where the delivery - more semantically - uses <hX>, hence styling is different
Does this still apply, after the branch in our repository was updated?
- notice for clients without javascript, formerly part of layout (no-js-notice from config / no_js_notice_template) not used/present anymore
This should be reintroduced for the new skin.
- its worth noting that non of the page titles in the content repo match the titles shown as navigation link anchors in the delivery, so they can not be reused like {$ 'use_of_resources'|trans( {}, 'pageTitles' ) $}
This is also the case in the currently used skin, isn't it?
https://github.com/wmde/FundraisingFrontend/pull/997 addresses findings T179930, T179929, T179936, T179931
https://github.com/wmde/FundraisingFrontend/pull/999 addresses finding T179940
Detected issues are tracked in separate tickets, scaffolding provided by this ticket is already in main line.