Page MenuHomePhabricator
Create Task
Maniphest T178186

Update Node.js version/dependencies in package.json
Closed, DeclinedPublic
Actions

Description

Per wt:Services/FirstDeployment#package.json, we should update package.json to include the version of Node.js that's required to run the project and a complete list of dependencies.

AC

Open Questions

  1. I'm assuming that Ops wouldn't be happy with the puppeteer library downloading a version of Chromium when the service is launched. So:
    1. Is this a genuine concern?
    2. Which version of Debian is used in production (on the SCB)?
    3. Which version of Chromium would be downloaded for that Debian version?
  2. Following on from #1, can we stop the puppeteer library from downloading a version of Chromium and rely on a package instead?

Related Objects
Search...

Event Timeline

phuedx created this task.Oct 13 2017, 5:34 PM
Jdlrobson moved this task from Incoming to Upcoming on the Web-Team-Backlog board.Oct 13 2017, 5:57 PM
• bmansurov subscribed.Oct 13 2017, 6:45 PM

I'm assuming that Ops wouldn't be happy with the puppeteer library downloading a version of Chromium when the service is launched.

Since we're using the deploy repo, all the binaries will be in that repository. So puppeteer will download chromium on first load, but that will only happen locally and commited to the deploy repo for use in production.

phuedx added a comment.Oct 17 2017, 10:46 AM
In T178186#3683971, @bmansurov wrote:

I'm assuming that Ops wouldn't be happy with the puppeteer library downloading a version of Chromium when the service is launched.

Since we're using the deploy repo, all the binaries will be in that repository. So puppeteer will download chromium on first load, but that will only happen locally and commited to the deploy repo for use in production.

Are we sure that we're running the same version of Debian locally as on the production servers? In T178189, it's been pointed out that there's a package available for Chromium already. Are we absolutely sure that we need a specific version of Chromium? If not, then we can do away with a little complexity; if so, then we could also create a package for that version (if it doesn't already exist) and make puppeteer skip the download.

• bmansurov added a comment.Oct 17 2017, 12:35 PM

We're not sure. This needs investigation.

phuedx updated the task description. (Show Details)Oct 17 2017, 12:50 PM
• bmansurov closed this task as Declined.Oct 31 2017, 4:32 PM

We discussed this during grooming. The node version is already up to date and we're not yet sure whether it's best to bundle chromium with puppeteer. Closing for now.

phuedx removed a parent task: T176627: Trial replacing Electron with headless Chromium in the render service.Nov 22 2017, 8:24 AM
phuedx added a parent task: T181118: [EPIC] Build a Chromium-based PDF renderer service.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits