Page MenuHomePhabricator

<references/> fails after Special:Prefixindex
Closed, ResolvedPublic

Description

Author: loustyx

Description:
A lost reference<ref>A lost reference</ref>.
{{Special:Prefixindex/Template:X}}
Another reference<ref>Another reference</ref>.
==Note==
<references/>

"A lost reference" is lost.


Version: unspecified
Severity: major
URL: http://test.wikipedia.org/wiki/Prefixindex%2Breferences

Details

Reference
bz15819

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 10:21 PM
bzimport added a project: Cite.
bzimport set Reference to bz15819.
bzimport added a subscriber: Unknown Object (MLST).

I can't reproduce this locally

matthew.britton wrote:

Doesn't happen on en.wikipedia either. But both are using the same MediaWiki version, so it's either an extension that's on test.wikipedia but not en.wikipedia or something in test.wikipedia's config.

proposed fix: clear state only if called from $wgParser

This happens, because there is only one Cite object, but two parsers ($wgParser and $wgMessageCache->mParser). Cite->clearState() should only trigger on calls by $wgParser, else it loses all references up to this point.

Easy fix attached.

Attached:

This fix fixes bug 16767 as well

nnwiki wrote:

Applied P.Copp's patch and fixed in r88971.

  • Bug 36177 has been marked as a duplicate of this bug. ***