Page MenuHomePhabricator
Create Task
Maniphest T178576

Include wikibase-data-values-value-view npm package as a submodule of Wikibase git repo
Closed, ResolvedPublic
Actions

Description

The repo of the npm package should be a submodule in Wikibase git repo.
Wikibase should define ResourceLoader modules including files from the npm package, that Wikibase uses.

Details

SubjectRepoBranchLines +/-
Install value-view lib as git submodule, not as composer dependencymediawiki/extensions/Wikibasemaster+787 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

WMDE-leszek claimed this task.Oct 19 2017, 2:26 PM
WMDE-leszek created this task.
WMDE-leszek added a project: Wikidata-Former-Sprint-Board.
WMDE-leszek moved this task from Proposed to Doing on the Wikidata-Former-Sprint-Board board.
WMDE-leszek renamed this task from Include wikibase-dataq-values-value-view npm package as a submodule of Wikibase git repo to Include wikibase-data-values-value-view npm package as a submodule of Wikibase git repo.Oct 19 2017, 2:28 PM
gerritbot subscribed.Oct 19 2017, 2:41 PM

Change 384943 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] [WIP] Install value-view lib as git submodule, not as composer dependency

https://gerrit.wikimedia.org/r/384943

gerritbot added a project: Patch-For-Review.Oct 19 2017, 2:41 PM
WMDE-leszek moved this task from Doing to Review on the Wikidata-Former-Sprint-Board board.Oct 21 2017, 5:51 AM
gerritbot added a comment.Nov 1 2017, 2:17 PM

Change 384943 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Install value-view lib as git submodule, not as composer dependency

https://gerrit.wikimedia.org/r/384943

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)).Nov 1 2017, 3:00 PM
WMDE-leszek closed this task as Resolved.Nov 2 2017, 11:51 AM
WMDE-leszek removed a project: Patch-For-Review.
WMDE-leszek moved this task from Review to Done on the Wikidata-Former-Sprint-Board board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL