Page MenuHomePhabricator
Create Task
Maniphest T178859

Switch MediaWiki to using PHPUnit 5.x
Closed, DeclinedPublic
Actions

Description

See PHPUnit\Util\Getopt uses deprecated each() function.

Version 5.7.23 seems to work.

Details

SubjectRepoBranchLines +/-
Update phpunit requirementmediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

MarkAHershberger created this task.Oct 24 2017, 12:02 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 24 2017, 12:02 AM
gerritbot subscribed.Oct 24 2017, 12:11 AM

Change 386118 had a related patch set uploaded (by MarkAHershberger; owner: MarkAHershberger):
[mediawiki/core@master] Update phpunit requirement

https://gerrit.wikimedia.org/r/386118

gerritbot added a project: Patch-For-Review.Oct 24 2017, 12:11 AM
Krinkle renamed this task from update phpunit requirement to one that doesn't use the deprecated each() to Switch MediaWiki to using PHPUnit 5.x.Oct 24 2017, 12:36 AM
Krinkle triaged this task as Low priority.
Krinkle edited projects, added MediaWiki-Core-Tests; removed Continuous-Integration-Infrastructure.
Krinkle added a subtask: T178538: Bump PHP requirement to 5.6 in 1.31.
Krinkle moved this task from Inbox to PHPUnit on the MediaWiki-Core-Tests board.
gerritbot added a comment.Oct 24 2017, 12:43 AM

Change 386118 abandoned by MarkAHershberger:
Update phpunit requirement

Reason:
abandoning for now, waiting for minimum php 5.6.

https://gerrit.wikimedia.org/r/386118

Ricordisamoa subscribed.Oct 28 2017, 4:23 PM
tstarling closed subtask T178538: Bump PHP requirement to 5.6 in 1.31 as Declined.Nov 22 2017, 11:00 PM
Krinkle removed a subtask: T178538: Bump PHP requirement to 5.6 in 1.31.Jan 10 2018, 10:59 PM
Krinkle removed a project: Patch-For-Review.Jan 10 2018, 11:05 PM
Krinkle subscribed.

Given T178538 (require PHP5.6) was declined and T172165 (require PHP7/HHVM) approved, we can probably upgrade from PHPUnit 4 to PHPUnit 6 directly, and decline this task as well, in favour of T177132.

Thoughts?

Legoktm closed this task as Declined.Feb 20 2018, 6:15 AM
Legoktm subscribed.

Declining in favor of jumping directly to PHPUnit 6.x.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits