Page MenuHomePhabricator

View events in Grant metrics
Closed, ResolvedPublic5 Estimated Story Points

Description

This ticket follows from T178823: 'My programs' landing page with program creation/deletion.

When user clicks on a program, they see all of the events.

Clicking on the event just takes user to a placeholder page.

Event Timeline

Niharika renamed this task from View and Create event in Grant metrics to View an event in Grant metrics.Nov 1 2017, 11:00 PM
Niharika updated the task description. (Show Details)
Niharika updated the task description. (Show Details)
kaldari renamed this task from View an event in Grant metrics to View events in Grant metrics.Nov 1 2017, 11:02 PM
kaldari set the point value for this task to 5.

Deployed to Toolforge! Some minor layout differences from the mock, mainly to preserve real estate for when programs have long names, or we have a lot of organizers, etc.

The main commit for this page, albeit somewhat outdated code, is at: https://github.com/wikimedia/grantmetrics/commit/4dd3d5b26466aab5943591f33cc9eda58a934494

Deployed to Toolforge! Some minor layout differences from the mock, mainly to preserve real estate for when programs have long names, or we have a lot of organizers, etc.

The main commit for this page, albeit somewhat outdated code, is at: https://github.com/wikimedia/grantmetrics/commit/4dd3d5b26466aab5943591f33cc9eda58a934494

Looks good. One minor thing - the delete/edit buttons would be always visible, not just on hover. And some padding on the left for the buttons, they are too close to the event title right now.

I see we skipped the duplicate icon right now. That's fine. I can add that in a new task later. Not high priority.

Looks good. One minor thing - the delete/edit buttons would be always visible, not just on hover. And some padding on the left for the buttons, they are too close to the event title right now.

Done, except I moved the buttons to a dedicated column just like in the mock, same with the Program list. Next to the title I thought works if only shown when hovering, but otherwise it's a bit hard on the eyes. I've removed the "Options" column heading to conserve space, too.

Instead of having a row in the table for the totals, how do you feel showing the snazzy statistics summary at the top, like we do for the event page?

Looks good. One minor thing - the delete/edit buttons would be always visible, not just on hover. And some padding on the left for the buttons, they are too close to the event title right now.

Done, except I moved the buttons to a dedicated column just like in the mock, same with the Program list. Next to the title I thought works if only shown when hovering, but otherwise it's a bit hard on the eyes. I've removed the "Options" column heading to conserve space, too.

Instead of having a row in the table for the totals, how do you feel showing the snazzy statistics summary at the top, like we do for the event page?

Not sure what you mean. The table is for giving a quick look at the stats for the events. The same stats are shown on the event page. What would the statistics summary on the programs page contain?

What would the statistics summary on the programs page contain?

The totals you see at the top of the table in the mock. But I guess that might look weird because the labels "Participants", "New editors", etc. would be repeated (in the stats summary and as the table column headings).

I currently get a 500 Internal Server Error when I try to log into Grant Metrics on Tool Forge, so I can't test there.

I currently get a 500 Internal Server Error when I try to log into Grant Metrics on Tool Forge, so I can't test there.

Is this still happening?

Nope, works great now!