| matmarex | |
| Nov 2 2017, 9:04 PM |
| F10576689: image.png | |
| Nov 2 2017, 9:04 PM |
| F10576925: image.png | |
| Nov 2 2017, 9:04 PM |
Polish Wikipedia template {{odn}} is inserted as a block element in VE rather than inline. (It generates a reference.)
Editing a random page, Insert → Template → type "odn" → type anything into the first field and a number into the second.
It looks like a paragraph gets inserted in wikitext around it:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix template rendering | mediawiki/extensions/VisualEditor | master | +37 -5 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T180185 FlowMention template makes impossible to type in the same line | |||
| Resolved | Esanders | T179618 Polish Wikipedia template {{odn}} is inserted as a block element in VE rather than inline |
When you ask Parsoid for a single ref it will <p> wrap it and also append a auto-generated ref list. We have code that removes the auto-generated ref list, and also unwraps documents that are a single paragraph. I suspect that they are happening in the wrong order though, so the paragraph unwrapping never happens because it thinks the document is more complex.
Hmm, ve.ce.MWTransclusionNode.static.filterRendering appears to be in the correct order. Investigating.
Looks like the problem is the newline text node between the paragraph and the autogenerated ref, so the paragraph unwrapping test fails.
Change 393059 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Fix template rendering
Change 393059 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Fix template rendering