Page MenuHomePhabricator
Create Task
Maniphest T180210

Improve test coverage for Revision class
Closed, ResolvedPublic
Actions

Description

These methods definitely need explicit test coverage:

Not quite as important, but should also be tested:

The following methods get tested only indirectly. This means that when they turn
into proxies for the new code, we don't know if they still do the right thing:

Details

Show related patches Customize query in gerrit

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
ResolveddanielT174038 Initial implementation of MCR page update interface
ResolvedAddshoreT180210 Improve test coverage for Revision class
· · ·

Event Timeline

Addshore created this task.Nov 10 2017, 10:55 AM
Restricted Application added a project: User-Addshore. · View Herald TranscriptNov 10 2017, 10:55 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Addshore moved this task from Unsorted 💣 to Back Burner 🏛️ on the User-Addshore board.Nov 10 2017, 10:57 AM
gerritbot subscribed.Nov 10 2017, 1:14 PM

Change 390399 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/core@master] Tests for Revision::decompressRevisionText

https://gerrit.wikimedia.org/r/390399

gerritbot added a project: Patch-For-Review.Nov 10 2017, 1:14 PM
Addshore updated the task description. (Show Details)Nov 10 2017, 1:14 PM
gerritbot added a comment.Nov 10 2017, 1:58 PM

Change 390405 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/core@master] Make Revision::testIsUnpatrolled more reliable

https://gerrit.wikimedia.org/r/390405

Addshore updated the task description. (Show Details)Nov 10 2017, 1:58 PM
gerritbot added a comment.Nov 10 2017, 2:10 PM

Change 390405 merged by jenkins-bot:
[mediawiki/core@master] Make Revision::testIsUnpatrolled more reliable

https://gerrit.wikimedia.org/r/390405

gerritbot added a comment.Nov 10 2017, 2:21 PM

Change 390399 merged by jenkins-bot:
[mediawiki/core@master] Tests for Revision::decompressRevisionText

https://gerrit.wikimedia.org/r/390399

daniel added a comment.Nov 10 2017, 2:35 PM

OOh, this is moving quickly! Thank you, guys!

gerritbot added a comment.Nov 10 2017, 2:38 PM

Change 390412 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/core@master] Test for Revision::newKnownCurrent

https://gerrit.wikimedia.org/r/390412

Addshore updated the task description. (Show Details)Nov 10 2017, 2:38 PM
daniel added a comment.Nov 10 2017, 2:55 PM

When all the tests have been added, please rebase https://gerrit.wikimedia.org/r/#/c/375050/ to see whether the tests still pass.

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)).Nov 10 2017, 3:00 PM
gerritbot added a comment.Nov 10 2017, 3:50 PM

Change 390424 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/core@master] Tests for Revision::userCanBitfield

https://gerrit.wikimedia.org/r/390424

Addshore updated the task description. (Show Details)Nov 10 2017, 3:50 PM
gerritbot added a comment.Nov 10 2017, 3:56 PM

Change 390425 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/core@master] Tests for Revision::userCan

https://gerrit.wikimedia.org/r/390425

Addshore updated the task description. (Show Details)Nov 10 2017, 3:56 PM
Addshore updated the task description. (Show Details)Nov 13 2017, 8:27 PM
Addshore updated the task description. (Show Details)Nov 13 2017, 8:31 PM
gerritbot added a comment.Nov 14 2017, 10:41 AM

Change 391183 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/core@master] Initial tests for Revision::getRevisionText

https://gerrit.wikimedia.org/r/391183

Addshore updated the task description. (Show Details)Nov 14 2017, 11:05 AM
gerritbot added a comment.Nov 14 2017, 12:04 PM

Change 391192 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/core@master] Tests for Revision::getRevisionText with ExternalStore usage

https://gerrit.wikimedia.org/r/391192

Addshore updated the task description. (Show Details)Nov 14 2017, 12:04 PM
Addshore updated the task description. (Show Details)Nov 14 2017, 12:15 PM
gerritbot added a comment.Nov 14 2017, 1:27 PM

Change 390412 merged by jenkins-bot:
[mediawiki/core@master] Test for Revision::newKnownCurrent

https://gerrit.wikimedia.org/r/390412

gerritbot added a comment.Nov 14 2017, 1:27 PM

Change 390424 merged by jenkins-bot:
[mediawiki/core@master] Tests for Revision::userCanBitfield

https://gerrit.wikimedia.org/r/390424

gerritbot added a comment.Nov 14 2017, 1:27 PM

Change 390425 merged by jenkins-bot:
[mediawiki/core@master] Tests for Revision::userCan

https://gerrit.wikimedia.org/r/390425

Addshore updated the task description. (Show Details)Nov 14 2017, 1:27 PM
gerritbot added a comment.Nov 14 2017, 1:30 PM

Change 391183 merged by jenkins-bot:
[mediawiki/core@master] Initial tests for Revision::getRevisionText

https://gerrit.wikimedia.org/r/391183

gerritbot added a comment.Nov 14 2017, 6:45 PM

Change 391192 merged by jenkins-bot:
[mediawiki/core@master] Tests for Revision::getRevisionText with ExternalStore usage

https://gerrit.wikimedia.org/r/391192

gerritbot added a comment.Nov 14 2017, 6:45 PM

Change 391194 merged by jenkins-bot:
[mediawiki/core@master] Test for Revision::getRecentChange

https://gerrit.wikimedia.org/r/391194

Addshore updated the task description. (Show Details)Nov 14 2017, 6:47 PM
Addshore updated the task description. (Show Details)Nov 14 2017, 6:50 PM
ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)); removed MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)).Nov 14 2017, 7:00 PM
gerritbot added a comment.Nov 15 2017, 10:38 AM

Change 391534 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/core@master] Revision::userCanBitfield test fallback to $wgUser

https://gerrit.wikimedia.org/r/391534

Addshore updated the task description. (Show Details)Nov 15 2017, 11:27 AM
Addshore added a comment.Nov 15 2017, 11:34 AM

@daniel I had written tests for the query related methods already, but they were removed in https://gerrit.wikimedia.org/r/#/c/383918/ with no replacements. Shall I write them again or?

daniel added a comment.Nov 16 2017, 4:54 PM

@Addshore I guess the tests were removed because the methods are now deprecated, and wfDeprecated makes tests fail.

I think that it's proper to keep testing deprecated methods. You can use setWgGlobals( 'wgDevelopmentWarnings' ) to allow the tests to execute. I suppose we should have a convenience method for that...

gerritbot added a comment.Nov 17 2017, 6:43 PM

Change 391534 merged by jenkins-bot:
[mediawiki/core@master] Revision::userCanBitfield test fallback to $wgUser

https://gerrit.wikimedia.org/r/391534

Addshore updated the task description. (Show Details)Nov 18 2017, 5:45 PM
gerritbot added a comment.Nov 18 2017, 5:51 PM

Change 392208 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/core@master] [MCR] Readd various field & cond method tests for Revision

https://gerrit.wikimedia.org/r/392208

gerritbot added a comment.Nov 18 2017, 6:22 PM

Change 392214 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/core@master] [MCR] tests for Revision::getArchiveQueryInfo

https://gerrit.wikimedia.org/r/392214

gerritbot added a comment.Nov 18 2017, 6:22 PM

Change 392215 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/core@master] [MCR] tests for Revision::getQueryInfo

https://gerrit.wikimedia.org/r/392215

Addshore updated the task description. (Show Details)Nov 18 2017, 6:23 PM
gerritbot added a comment.Nov 18 2017, 7:34 PM

Change 392208 merged by jenkins-bot:
[mediawiki/core@master] [MCR] Readd various field & cond method tests for Revision

https://gerrit.wikimedia.org/r/392208

gerritbot added a comment.Nov 18 2017, 7:35 PM

Change 392214 merged by jenkins-bot:
[mediawiki/core@master] [MCR] tests for Revision::getArchiveQueryInfo

https://gerrit.wikimedia.org/r/392214

gerritbot added a comment.Nov 18 2017, 7:38 PM

Change 392215 merged by jenkins-bot:
[mediawiki/core@master] [MCR] tests for Revision::getQueryInfo

https://gerrit.wikimedia.org/r/392215

Addshore updated the task description. (Show Details)Nov 20 2017, 3:38 PM
Addshore renamed this task from Test coverage for Revision class to Improve test coverage for Revision class.Nov 20 2017, 7:29 PM
Addshore added a project: Multi-Content-Revisions.
Addshore moved this task from Inbox to Next on the Multi-Content-Revisions board.
gerritbot added a comment.Nov 20 2017, 8:14 PM

Change 392484 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/core@master] More user related Revision construction test cases

https://gerrit.wikimedia.org/r/392484

Addshore updated the task description. (Show Details)Nov 22 2017, 11:01 PM
gerritbot added a comment.Nov 24 2017, 1:00 PM

Change 392484 merged by jenkins-bot:
[mediawiki/core@master] More user related Revision construction test cases

https://gerrit.wikimedia.org/r/392484

Addshore closed this task as Resolved.Dec 4 2017, 6:24 PM

I'd consider this improved...

Addshore moved this task from Back Burner 🏛️ to Closing ✔️ on the User-Addshore board.Dec 4 2017, 6:24 PM
CCicalese_WMF moved this task from Next to Done on the Multi-Content-Revisions board.May 10 2018, 4:47 PM
CCicalese_WMF moved this task from Done to MCR-SDC Storage Layer - phase 1 on the Multi-Content-Revisions board.May 10 2018, 4:49 PM
CCicalese_WMF edited projects, added Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1); removed Multi-Content-Revisions.
CCicalese_WMF moved this task from Backlog to Done on the Multi-Content-Revisions (MCR-SDC Storage Layer - phase 1) board.May 10 2018, 5:08 PM
CCicalese_WMF added a parent task: T174038: Initial implementation of MCR page update interface.May 31 2018, 2:38 AM
CCicalese_WMF removed a project: Patch-For-Review.Jun 1 2018, 12:56 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits