Page MenuHomePhabricator
Create Task
Maniphest T180835

Re-show nav bar when making TOC selections
Closed, ResolvedPublic
Actions

Related Objects

Event Timeline

Mhurd created this task.Nov 17 2017, 7:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 17 2017, 7:11 PM
Mhurd moved this task from Tasks from Product Backlog to Doing on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.Nov 17 2017, 7:13 PM
Mhurd added a subscriber: • JMinor.

@JMinor

Adding this to 5.8 per conversation at yesterday's task sync.

Mhurd added a comment.Nov 17 2017, 7:24 PM

https://github.com/wikimedia/wikipedia-ios/pull/1938

Mhurd moved this task from Doing to Needs Code Review on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.Nov 17 2017, 7:24 PM
• NHarateh_WMF mentioned this in rAPIOS27e42f739db4: Merge pull request #1938 from wikimedia/bug/reshow-nav-on-toc-select/T180835.Nov 17 2017, 7:58 PM
Mhurd moved this task from Needs Code Review to Needs Testing Criteria on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.Nov 17 2017, 10:29 PM
• JMinor triaged this task as Low priority.Nov 27 2017, 8:15 PM
• JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.
Mhurd added a comment.Nov 29 2017, 12:53 AM

Testing criteria

For tablet and phone:

  • load any article
  • scroll down a bit in the article until the top navigation bar goes away
  • tap the TOC icon and make a selection from a different section than the one you are currently seeing
  • ensure the top navigation bar has re-appeared after TOC selection is made
Mhurd moved this task from Needs Testing Criteria to Needs Design Review on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.Nov 29 2017, 12:54 AM
cmadeo moved this task from Needs Design Review to Needs QA on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.Nov 30 2017, 9:11 PM
cmadeo subscribed.

Looking good! Thanks!

Nicholas.tsg subscribed.Dec 5 2017, 9:47 PM

Testing on iPhone 6 Plus (iOS 11.1.2) and Wikipedia app 5.7.2 (1267). According to the attached video making a ToC selection still doesn't make the navigation bar re-appear (however, this may not be quite what is wanted, it does reappear if you scroll up a bit in the article afterwards).

T180835.wmv1 MBDownload

ABorbaWMF subscribed.Dec 13 2017, 10:37 PM

Working for me on Wikipedia app 5.7.3 (1281). @Nicholas.tsg, can you retest this one as well?

ABorbaWMF moved this task from Needs QA to Ready for PM Signoff on the iOS-app-v5.7.4-Dachshund-On-An-Elk board.Dec 15 2017, 5:58 PM

Moving to sign-off

• JMinor closed this task as Resolved.Jan 8 2018, 10:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits