Page MenuHomePhabricator
Create Task
Maniphest T181184

Timeless cancels out value of the cellpadding attribute
Closed, ResolvedPublic
Actions

Description

This is more of a documentation task than anything, but Timeless doesn't seem to understand cellpadding. I personally don't have a problem with this behavior (it will help identify off the cuff where changes should be made to bring Wiki* into the 21st century of HTML), which is why I'm noting it as documentation, but I might reasonably suggest this will be unexpected. 🙂

There are some other rendering differences there too on Firefox 57 on Windows 10, but that one immediately jumps at you.

Details

SubjectRepoBranchLines +/-
Kill weird table normalisationmediawiki/skins/Timelessmaster+0 -17
Customize query in gerrit

Related Objects

Event Timeline

Izno created this task.Nov 22 2017, 6:27 PM
SamanthaNguyen subscribed.EditedNov 22 2017, 6:39 PM

Timeless uses Normalise (a CSS reset stylesheet) which applies a generic rule to td and th elements. See https://github.com/wikimedia/mediawiki-skins-Timeless/blob/master/resources/libraries/normalise.css#L409:

td,
th {
	padding: 0;
}

This CSS cancels out the cellpadding value as it has a higher specificity level.

SamanthaNguyen renamed this task from Timeless doesn't understand obsolete HTML (at least cellpadding) to Timeless cancels out value of the cellpadding attribute.Nov 22 2017, 6:45 PM
SamanthaNguyen added a comment.Nov 22 2017, 6:48 PM

To be more specific.. understanding what an HTML attribute and recognizing it, is done at at the web browser level.

Izno added a comment.Nov 22 2017, 6:49 PM
In T181184#3782296, @SamanthaNguyen wrote:

To be more specific.. understanding what an HTML attribute and recognizing it, is done at at the web browser level.

Assuming the attribute in question makes it through the MediaWiki whitelist, which is what was confusing to me in general.

SamanthaNguyen added a comment.Nov 22 2017, 6:54 PM

That would be MediaWiki's parser, which decides what to output to the browser.

TheDJ subscribed.Nov 24 2017, 8:23 AM

See also: T161423

Izno added a comment.Nov 24 2017, 12:50 PM
In T181184#3784856, @TheDJ wrote:

See also: T161423

Worth merging? The root cause is the same, even if infobox CSS is on Wiki* rather than in the skin.

SamanthaNguyen unsubscribed.Jun 30 2018, 7:13 PM
Isarra claimed this task.May 14 2019, 9:37 PM
Isarra subscribed.

Okay fine I hate you all I'll fix this.

Restricted Application added a subscriber: Liuxinyu970226. · View Herald TranscriptMay 14 2019, 9:37 PM
Isarra merged a task: T161423: Infoboxes missing padding.May 14 2019, 9:37 PM

In contrast to the other skins, Timeless sets border-collapse: collapse and border-spacing: 0 to all tables, including all tables in the content area. The issue can be fixed by just removing these two properties, or making their selector more specific so it does not cover inboxes and such.

General note that we might want both of those things, not just the one listed here.

Isarra added a comment.May 14 2019, 9:43 PM

Also I'm kidding I love you guys.

Izno added a comment.May 14 2019, 9:57 PM
In T181184#5182941, @Isarra wrote:

Okay fine I hate you all I'll fix this.

In T181184#5182954, @Isarra wrote:

Also I'm kidding I love you guys.

I don't know how to feel anymore.

Izno mentioned this in T220255: Timeless wikitable styles are bad.Jul 28 2019, 4:33 PM
gerritbot added a comment.Aug 26 2019, 3:16 AM

Change 532285 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/Timeless@master] Kill weird table normalisation

https://gerrit.wikimedia.org/r/532285

gerritbot added a project: Patch-For-Review.Aug 26 2019, 3:16 AM
Isarra moved this task from Backlog to In progress, or perhaps should be on the Timeless board.Aug 26 2019, 3:17 AM
gerritbot added a comment.Aug 27 2019, 5:23 PM

Change 532285 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Kill weird table normalisation

https://gerrit.wikimedia.org/r/532285

Restricted Repository Identity mentioned this in rSKIN5e9005a538d6: Update git submodules.Aug 27 2019, 5:24 PM
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.21; 2019-09-03).Aug 27 2019, 6:00 PM
Isarra closed this task as Resolved.Aug 27 2019, 9:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL