[BetaFeatures] Fatal error: Declaration of HTMLFeatureField::getInputHTML($value) must be compatible with NewHTMLCheckField::getInputHTML($value, $attr = NULL)
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	RazeSoldier
	Dec 1 2017, 5:17 PM

Description

Today, I upgraded php7.1 to php7.2. Page tell me:

Fatal error: Declaration of HTMLFeatureField::getInputHTML($value) must be compatible with NewHTMLCheckField::getInputHTML($value, $attr = NULL) in /InstallPath/w/extensions/BetaFeatures/includes/HTMLFeatureField.php on line 26

I can promise that I haven't edit any files.

I try to fix this error, then I solved this error:
I modified the parameter of getInputHTML() method to

function getInputHTML( $value, $attr = NULL ) {

on includes/HTMLFeatureField.php in 283 line.
My wiki info are:

MediaWiki	1.29.1
PHP	7.2.0 (cgi-fcgi)
MariaDB	10.2.10-MariaDB-log
ICU	52.1
Lua	5.1.5

Details

	Subject	Repo	Branch	Lines +/-
	Compatible with php7.2	mediawiki/extensions/BetaFeatures	REL1_30	+1 -1
	Compatible with php7.2	mediawiki/extensions/BetaFeatures	master	+1 -1

Customize query in gerrit

Event Timeline

RazeSoldier created this task.Dec 1 2017, 5:17 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 1 2017, 5:17 PM

RazeSoldier renamed this task from Fatal error: Declaration of HTMLFeatureField::getInputHTML($value) must be compatible with NewHTMLCheckField::getInputHTML($value, $attr = NULL) to [BetaFeatures] Fatal error: Declaration of HTMLFeatureField::getInputHTML($value) must be compatible with NewHTMLCheckField::getInputHTML($value, $attr = NULL).Dec 1 2017, 5:19 PM

RazeSoldier moved this task from Unsorted to PHP 7.2 on the [DO NOT USE] NewPHP board.Dec 1 2017, 5:21 PM

Thanks for taking a look at the code and reporting this!

You are very welcome to use developer access to submit the proposed code changes as a Git branch directly into Gerrit which makes it easier to review them quickly and provide feedback.
If you don't want to set up Git/Gerrit, you can also use the Gerrit Patch Uploader. Thanks again!

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptDec 1 2017, 9:04 PM

Change 394739 had a related patch set uploaded (by 星耀晨曦; owner: 星耀晨曦):
[mediawiki/extensions/BetaFeatures@master] Compatible with php7.2

https://gerrit.wikimedia.org/r/394739

gerritbot added a project: Patch-For-Review.Dec 2 2017, 3:34 AM

RazeSoldier moved this task from Backlog to Doing on the BetaFeatures board.Dec 2 2017, 1:27 PM

Framawiki moved this task from Backlog to Doing on the good first task board.Dec 2 2017, 1:28 PM

RazeSoldier renamed this task from [BetaFeatures] Fatal error: Declaration of HTMLFeatureField::getInputHTML($value) must be compatible with NewHTMLCheckField::getInputHTML($value, $attr = NULL) to [BetaFeatures] Fatal error: Declaration of HTMLFeatureField::getInputHTML($value) must be compatible with NewHTMLCheckField::getInputHTML($value, $attr = NULL) in PHP 7.2.Dec 2 2017, 4:15 PM

Not a PHP 7.2 bug

Reedy renamed this task from [BetaFeatures] Fatal error: Declaration of HTMLFeatureField::getInputHTML($value) must be compatible with NewHTMLCheckField::getInputHTML($value, $attr = NULL) in PHP 7.2 to Fatal error: Declaration of HTMLFeatureField::getInputHTML($value) must be compatible with NewHTMLCheckField::getInputHTML($value, $attr = NULL).Dec 3 2017, 12:13 AM

Change 394739 merged by jenkins-bot:
[mediawiki/extensions/BetaFeatures@master] Compatible with php7.2

https://gerrit.wikimedia.org/r/394739

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)).Dec 3 2017, 8:00 AM

@Legoktm As you said in gerrit,
{F11153965}This is my fatal error.

RazeSoldier closed this task as Resolved.Dec 4 2017, 11:50 PM

RazeSoldier removed projects: MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)), Patch-For-Review.Dec 5 2017, 5:45 AM

I deleted more than one tag. :-)

Change 427533 had a related patch set uploaded (by Paladox; owner: RazeSoldier):
[mediawiki/extensions/BetaFeatures@REL1_30] Compatible with php7.2

https://gerrit.wikimedia.org/r/427533

gerritbot added a project: Patch-For-Review.Apr 18 2018, 8:29 PM

Change 427533 merged by jenkins-bot:
[mediawiki/extensions/BetaFeatures@REL1_30] Compatible with php7.2

https://gerrit.wikimedia.org/r/427533

[BetaFeatures] Fatal error: Declaration of HTMLFeatureField::getInputHTML($value) must be compatible with NewHTMLCheckField::getInputHTML($value, $attr = NULL)Closed, ResolvedPublicActions

Description

Details

Event Timeline

[BetaFeatures] Fatal error: Declaration of HTMLFeatureField::getInputHTML($value) must be compatible with NewHTMLCheckField::getInputHTML($value, $attr = NULL)
Closed, ResolvedPublic
Actions