Page MenuHomePhabricator
Create Task
Maniphest T181950

Wrong Namespace shown on second page
Closed, ResolvedPublic
Actions

Assigned To
WMDE-Fisch
Authored By
• MichaelSchoenitzer_WMDE
Dec 3 2017, 10:46 PM
Tags
Referenced Files
F11189898: image.png
Dec 5 2017, 10:48 AM
F11174260: advsearch2.png
Dec 4 2017, 12:15 PM
Subscribers
Addshore
Aklapper
gerritbot
Huji
• MichaelSchoenitzer_WMDE
Tokens
"Meh!" token, awarded by Addshore."Like" token, awarded by Huji.

Description

When you submitted a search using AdvancedSearch, and then change the page of the search results, all your AdvancedSearch input is emptied, and put in the general search box instead.

advsearch2.png (358×556 px, 33 KB)

Acceptance Criteria

  • After having search with AdvancedSearch (be it in the form or the namespaces), I can change the page of the search results without changing the way the search terms are displayed. This means, everything I entered in AdvancedSearch will still be in AdvancedSearch

Details

SubjectRepoBranchLines +/-
Add search state parameters to result linksmediawiki/extensions/AdvancedSearchmaster+8 -0
Customize query in gerrit

Related Objects

Event Timeline

• MichaelSchoenitzer_WMDE created this task.Dec 3 2017, 10:46 PM
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptDec 3 2017, 10:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Huji subscribed.Dec 4 2017, 3:31 AM
This comment was removed by Huji.
Huji awarded a token.Dec 4 2017, 3:32 AM
• MichaelSchoenitzer_WMDE updated the task description. (Show Details)Dec 4 2017, 12:15 PM
• Lea_WMDE added a project: WMDE-TechWish.Dec 4 2017, 5:23 PM
Addshore awarded a token.Dec 5 2017, 10:47 AM
Addshore subscribed.

Example:

Page1: https://de.wikipedia.org/w/index.php?advancedSearchOption-original=berlin+foo&search=berlin+foo&title=Spezial:Suche&profile=advanced&fulltext=1&advancedSearchOption-filetype=&advancedSearch-current=%7B%22options%22%3A%7B%7D%2C%22namespaces%22%3A%5B%222%22%5D%7D&ns2=1&searchToken=4ox75teiebt0568w3cbyd6pw7
The link to Page2: https://de.wikipedia.org/w/index.php?title=Spezial:Suche&limit=20&offset=20&ns2=1&search=berlin+foo&searchToken=9ono1g6yzrdo0qjrynerct5m9

All pagey links at the bottom will also have a similar issue and should all be updated

image.png (33×372 px, 3 KB)

• Lea_WMDE moved this task from Proposed to Sprint ready on the WMDE-TechWish board.Dec 11 2017, 11:40 AM
Tobi_WMDE_SW moved this task from Sprint ready to Todo on the WMDE-TechWish board.Dec 13 2017, 2:09 PM
Tobi_WMDE_SW moved this task from Todo to Currently in sprint on the WMDE-TechWish board.
Tobi_WMDE_SW added a project: WMDE-QWERTY-Sprint-2017-12-13.Dec 13 2017, 2:16 PM
• Lea_WMDE triaged this task as Medium priority.Dec 14 2017, 11:46 AM
• Lea_WMDE updated the task description. (Show Details)
• Lea_WMDE moved this task from Backlog to Doing (others) on the Advanced-Search board.Dec 15 2017, 10:52 AM
WMDE-Fisch claimed this task.Dec 18 2017, 4:27 PM
WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2017-12-13 board.
gerritbot subscribed.Dec 18 2017, 5:43 PM

Change 398886 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/AdvancedSearch@master] Add search state parameters to result links

https://gerrit.wikimedia.org/r/398886

gerritbot added a project: Patch-For-Review.Dec 18 2017, 5:43 PM
WMDE-Fisch moved this task from Doing to Review on the WMDE-QWERTY-Sprint-2017-12-13 board.Dec 18 2017, 5:44 PM
WMDE-Fisch mentioned this in rEASR6cdef6ed170e: Add search state parameters to result links.Dec 18 2017, 5:45 PM
gerritbot added a comment.Dec 19 2017, 12:27 PM

Change 398886 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Add search state parameters to result links

https://gerrit.wikimedia.org/r/398886

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)).Dec 19 2017, 1:00 PM
WMDE-Fisch moved this task from Review to Done on the WMDE-QWERTY-Sprint-2017-12-13 board.Dec 19 2017, 1:58 PM
Tobi_WMDE_SW closed this task as Resolved.Jan 9 2018, 12:51 PM
Tobi_WMDE_SW moved this task from Currently in sprint to Done on the WMDE-TechWish board.
• Lea_WMDE moved this task from Done to Demoed on the WMDE-TechWish board.Feb 20 2018, 3:32 PM
• Lea_WMDE moved this task from Doing (others) to In FUN sprint on the Advanced-Search board.Dec 4 2018, 9:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL