Page MenuHomePhabricator

Flow test failures locally with LQT enabled
Closed, ResolvedPublicPRODUCTION ERROR

Description

There were 4 failures:

1) Flow\Tests\Import\LiquidThreadsApi\ConversionStrategyTest::testCreateArchiveCleanupRevisionContent with data set #0 ('Blank input page', '{{Archive for converted LQT p...:0}}\n\n', '')
Blank input page
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
 '{{Archive for converted LQT page|from=Talk:Blue birds|date=2017-12-04}}
 
 {{#useliquidthreads:0}}
 
+
+
+{{#useliquidthreads:0}}
+
 '

/var/www/wiki/mediawiki/extensions/Flow/tests/phpunit/Import/LiquidThreadsApi/ConversionStrategyTest.php:143
/var/www/wiki/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:416
/var/www/wiki/mediawiki/core/maintenance/doMaintenance.php:94

2) Flow\Tests\Import\LiquidThreadsApi\ConversionStrategyTest::testCreateArchiveCleanupRevisionContent with data set #1 ('Page containing lqt magic word', '{{Archive for converted LQT p...:0}}\n\n', '{{#useliquidthreads:1}}')
Page containing lqt magic word
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
 '{{Archive for converted LQT page|from=Talk:Blue birds|date=2017-12-04}}
 
 {{#useliquidthreads:0}}
 
+
+
+{{#useliquidthreads:0}}
+
 '

/var/www/wiki/mediawiki/extensions/Flow/tests/phpunit/Import/LiquidThreadsApi/ConversionStrategyTest.php:143
/var/www/wiki/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:416
/var/www/wiki/mediawiki/core/maintenance/doMaintenance.php:94

3) Flow\Tests\Import\LiquidThreadsApi\ConversionStrategyTest::testCreateArchiveCleanupRevisionContent with data set #2 ('Page containing some stuff an...c word', '{{Archive for converted LQT p...qual.\n', 'Four score and seven years ag...\n	1\n}}')
Page containing some stuff and the lqt magic word
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
 '{{Archive for converted LQT page|from=Talk:Blue birds|date=2017-12-04}}
 
 {{#useliquidthreads:0}}
 
+
+
+{{#useliquidthreads:0}}
+
 Four score and seven years ago our fathers brought forth
 on this continent, a new nation, conceived in Liberty, and
 dedicated to the proposition that all men are created equal.
 '

/var/www/wiki/mediawiki/extensions/Flow/tests/phpunit/Import/LiquidThreadsApi/ConversionStrategyTest.php:143
/var/www/wiki/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:416
/var/www/wiki/mediawiki/core/maintenance/doMaintenance.php:94

4) Flow\Tests\Import\Wikitext\ConversionStrategyTest::testShouldConvertLqt
Normal non-LQT talk page should be converted
Failed asserting that false matches expected true.

/var/www/wiki/mediawiki/extensions/Flow/tests/phpunit/Import/Wikitext/ConversionStrategyTest.php:105
/var/www/wiki/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:416
/var/www/wiki/mediawiki/core/maintenance/doMaintenance.php:94

This shows as

#!/usr/bin/env php
Using PHP 7.1.11-0ubuntu0.17.10.1
PHPUnit 4.8.36 by Sebastian Bergmann and contributors.
.......................................SS......................  63 / 514 ( 12%)
............................................................... 126 / 514 ( 24%)
....................SSSS..........................FFF.......... 189 / 514 ( 36%)
............F.....SSSSSSSSSSSSSSSSSSSSSSSSSSSS................. 252 / 514 ( 49%)
............................................SSSSSSSSSS......... 315 / 514 ( 61%)
............................................................... 378 / 514 ( 73%)
..................................................SSSS......... 441 / 514 ( 85%)
............................................................... 504 / 514 ( 98%)
..........

Time: 1.7 minutes, Memory: 96.00MB

And with LQT disabled, they're just skipped

reedy@ubuntu64-web-esxi:/var/www/wiki/mediawiki/core$ php tests/phpunit/phpunit.php extensions/Flow/tests/phpunit/
#!/usr/bin/env php
Using PHP 7.1.11-0ubuntu0.17.10.1
PHPUnit 4.8.36 by Sebastian Bergmann and contributors.

.......................................SS......................  63 / 514 ( 12%)
............................................................... 126 / 514 ( 24%)
....................SSSS..........................SSS.......... 189 / 514 ( 36%)
............S.....SSSSSSSSSSSSSSSSSSSSSSSSSSSS................. 252 / 514 ( 49%)
............................................SSSSSSSSSS......... 315 / 514 ( 61%)
............................................................... 378 / 514 ( 73%)
..................................................SSSS......... 441 / 514 ( 85%)
............................................................... 504 / 514 ( 98%)
..........

Time: 1.65 minutes, Memory: 96.00MB

OK, but incomplete, skipped, or risky tests!
Tests: 514, Assertions: 1301, Skipped: 52.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Still failing...

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/48392/console

19:21:18 1) Flow\Tests\Import\LiquidThreadsApi\ConversionStrategyTest::testCreateArchiveCleanupRevisionContent with data set #0 ('Blank input page', '{{Archive for converted LQT p...:0}}\n\n', '')
19:21:18 Blank input page
19:21:18 Failed asserting that two strings are equal.
19:21:18 --- Expected
19:21:18 +++ Actual
19:21:18 @@ @@
19:21:18  '{{Archive for converted LQT page|from=Talk:Blue birds|date=2019-05-10}}
19:21:18  
19:21:18  {{#useliquidthreads:0}}
19:21:18  
19:21:18 +
19:21:18 +
19:21:18 +{{#useliquidthreads:0}}
19:21:18 +
19:21:18  '
19:21:18 
19:21:18 /workspace/src/extensions/Flow/tests/phpunit/Import/LiquidThreadsApi/ConversionStrategyTest.php:148
19:21:18 /workspace/src/tests/phpunit/MediaWikiTestCase.php:427
19:21:18 /workspace/src/maintenance/doMaintenance.php:96
19:21:18 
19:21:18 2) Flow\Tests\Import\LiquidThreadsApi\ConversionStrategyTest::testCreateArchiveCleanupRevisionContent with data set #1 ('Page containing lqt magic word', '{{Archive for converted LQT p...:0}}\n\n', '{{#useliquidthreads:1}}')
19:21:18 Page containing lqt magic word
19:21:18 Failed asserting that two strings are equal.
19:21:18 --- Expected
19:21:18 +++ Actual
19:21:18 @@ @@
19:21:18  '{{Archive for converted LQT page|from=Talk:Blue birds|date=2019-05-10}}
19:21:18  
19:21:18  {{#useliquidthreads:0}}
19:21:18  
19:21:18 +
19:21:18 +
19:21:18 +{{#useliquidthreads:0}}
19:21:18 +
19:21:18  '
19:21:18 
19:21:18 /workspace/src/extensions/Flow/tests/phpunit/Import/LiquidThreadsApi/ConversionStrategyTest.php:148
19:21:18 /workspace/src/tests/phpunit/MediaWikiTestCase.php:427
19:21:18 /workspace/src/maintenance/doMaintenance.php:96
19:21:18 
19:21:18 3) Flow\Tests\Import\LiquidThreadsApi\ConversionStrategyTest::testCreateArchiveCleanupRevisionContent with data set #2 ('Page containing some stuff an...c word', '{{Archive for converted LQT p...qual.\n', 'Four score and seven years ag...\n	1\n}}')
19:21:18 Page containing some stuff and the lqt magic word
19:21:18 Failed asserting that two strings are equal.
19:21:18 --- Expected
19:21:18 +++ Actual
19:21:18 @@ @@
19:21:18  '{{Archive for converted LQT page|from=Talk:Blue birds|date=2019-05-10}}
19:21:18  
19:21:18  {{#useliquidthreads:0}}
19:21:18  
19:21:18 +
19:21:18 +
19:21:18 +{{#useliquidthreads:0}}
19:21:18 +
19:21:18  Four score and seven years ago our fathers brought forth
19:21:18  on this continent, a new nation, conceived in Liberty, and
19:21:18  dedicated to the proposition that all men are created equal.
19:21:18  '
19:21:18 
19:21:18 /workspace/src/extensions/Flow/tests/phpunit/Import/LiquidThreadsApi/ConversionStrategyTest.php:148
19:21:18 /workspace/src/tests/phpunit/MediaWikiTestCase.php:427
19:21:18 /workspace/src/maintenance/doMaintenance.php:96
19:21:18 
19:21:18 4) Flow\Tests\Import\Wikitext\ConversionStrategyTest::testShouldConvertLqt
19:21:18 Normal non-LQT talk page should be converted
19:21:18 Failed asserting that false matches expected true.
19:21:18 
19:21:18 /workspace/src/extensions/Flow/tests/phpunit/Import/Wikitext/ConversionStrategyTest.php:110
19:21:18 /workspace/src/tests/phpunit/MediaWikiTestCase.php:427
19:21:18 /workspace/src/maintenance/doMaintenance.php:96

Change 509490 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/Flow@master] Disable broken tests

https://gerrit.wikimedia.org/r/509490

Change 509490 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Disable broken tests

https://gerrit.wikimedia.org/r/509490

Change 509806 had a related patch set uploaded (by Krinkle; owner: Kosta Harlan):
[mediawiki/extensions/Flow@wmf/1.34.0-wmf.4] Disable broken tests

https://gerrit.wikimedia.org/r/509806

Change 509806 merged by jenkins-bot:
[mediawiki/extensions/Flow@wmf/1.34.0-wmf.4] Disable broken tests

https://gerrit.wikimedia.org/r/509806

Reedy assigned this task to kostajh.
Reedy removed a project: Patch-For-Review.
mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:09 PM