Page MenuHomePhabricator
Create Task
Maniphest T182026

Notice: Undefined index: collection_id|writer|is_cached
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

https://logstash.wikimedia.org/app/kibana#/discover?_g=(refreshInterval:(display:Off,pause:!f,value:0),time:(from:now-30d,mode:quick,to:now))&_a=(columns:!(_source),index:'logstash-*',interval:auto,query:(query_string:(analyze_wildcard:!t,query:'message:%22Collection%22+AND+level:%22NOTICE%22')),sort:!('@timestamp',desc))

  • Notice: Undefined index: collection_id
  • Notice: Undefined index: writer
  • Notice: Undefined index: is_cached
Notice: Undefined index: is_cached in /srv/mediawiki/php-1.31.0-wmf.8/extensions/Collection/Collection.body.php on line 1065

Details

SubjectRepoBranchLines +/-
Better undefined index protectionmediawiki/extensions/Collectionmaster+4 -4
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Dec 4 2017, 7:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 4 2017, 7:44 PM
Jdlrobson renamed this task from Notice: Undefined index: collection_id, Notice: Undefined index: writer to Notice: Undefined index: collection_id|writer|is_cached.Dec 4 2017, 7:46 PM
Jdlrobson updated the task description. (Show Details)
• demon subscribed.Dec 4 2017, 8:26 PM

Wasn't is_cached fixed in master?

gerritbot subscribed.Dec 4 2017, 9:58 PM

Change 395115 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Collection@master] Better undefined index protection

https://gerrit.wikimedia.org/r/395115

gerritbot added a project: Patch-For-Review.Dec 4 2017, 9:58 PM
Jdlrobson added a comment.Dec 4 2017, 9:58 PM

Untested, but I imagine this should make the problem go away... ^

• demon moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.Dec 15 2017, 12:21 AM
Krinkle closed this task as Resolved.Jul 11 2018, 2:00 AM
Krinkle claimed this task.
Krinkle subscribed.

No longer appears in any recent logs. Seems fixed.

Note, there is another "Undefined index" error trending from Collection, tracked at T189636: Undefined 'subtitle' and 'title' indexes in CollectionPageTemplate.php.

Krinkle removed a project: Patch-For-Review.Jul 11 2018, 2:00 AM
gerritbot added a comment.Aug 2 2018, 8:35 PM

Change 395115 merged by jenkins-bot:
[mediawiki/extensions/Collection@master] Better undefined index protection

https://gerrit.wikimedia.org/r/395115

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)).Aug 2 2018, 9:01 PM
Krinkle moved this task from Dec2019/1.35.wmf.10+ to Resolved on the Wikimedia-production-error board.May 29 2019, 4:01 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:09 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL